set msn/display_name foo is ignored

[vmiklos@…]

hi,

it seems something is broken with the set msn/display_name feature. i have printfs at the begining of msn_set_display_name() but it's only called when i use 'nick msn foo', not when i use 'set msn/display_name foo'

this is bzr revision 313

thanks,

• VMiklos

[wilmer]

Are you sure this is broken? It works for me.

[VMiklos <vmiklos@…>]

okay, i wanted to do a bit more test, but i hit a simple segfault now :)

rev323 of ​http://code.bitlbee.org/bitlbee/

Program received signal SIGSEGV, Segmentation fault.
0x0805eef9 in set_find (head=0x80c4734, key=0x80aea70 "private") at set.c:68
68                      if( g_strcasecmp( s->key, key ) == 0 )
(gdb) bt
#0  0x0805eef9 in set_find (head=0x80c4734, key=0x80aea70 "private") at set.c:68
#1  0x0805ef3b in set_getstr (head=0x80c4734, key=0x80aea70 "private") at set.c:78
#2  0x0805f006 in set_getbool (head=0x80c4734, key=0x80aea70 "private") at set.c:102
#3  0x08061a9a in user_add (irc=0x80c46c0, nick=0x80c47f0 "root") at user.c:69
#4  0x08058519 in irc_login (irc=0x80c46c0) at irc.c:715
#5  0x080583e7 in irc_check_login (irc=0x80c46c0) at irc.c:691
#6  0x08059d02 in irc_cmd_user (irc=0x80c46c0, cmd=0x80dea78) at irc_commands.c:48
#7  0x0805b7e6 in irc_exec (irc=0x80c46c0, cmd=0x80dea78) at irc_commands.c:650
#8  0x0805771d in irc_process (irc=0x80c46c0) at irc.c:345
#9  0x0805404a in bitlbee_io_current_client_read (data=0x80c46c0, fd=10, cond=GAIM_INPUT_READ) at bitlbee.c:181
#10 0x08062a63 in gaim_io_invoke (source=0x80c4758, condition=G_IO_IN, data=0x80c4748) at events_glib.c:83
#11 0xb7e88afd in g_io_unix_dispatch () from /usr/lib/libglib-2.0.so.0
#12 0xb7e59256 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#13 0xb7e5c612 in g_main_context_iterate () from /usr/lib/libglib-2.0.so.0
#14 0xb7e5c9f7 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#15 0x080629f4 in b_main_run () at events_glib.c:62
#16 0x08061676 in main (argc=4, argv=0xbff2afb4, envp=0xbff2afc8) at unix.c:129

contents of /var/lib/bitlbee/vmiklos.xml:

<user nick="vmiklos" password="foo" version="1">
        <setting name="away_devoice">false</setting>
        <account protocol="skype" handle="blah" password="bar" autoconnect="1" server="localhost">
        </account>
        <account protocol="msn" handle="baz" password="bar" autoconnect="1">
        </account>
</user>

kind of cryptic, anything i can post here to help debugging?

(yes, i tried to disable the skype plugin in case that would help, but no success.)

thanks

[wilmer]

Hmm yes, that's odd. Can you print s and *head?

[wilmer]

Oh, BTW, I wonder if maybe you just ran bzr pull && make without running make clean first? Possibly a headerfile changed. The dependencies in the Makefiles aren't very accurate, unfortunately.

[VMiklos <vmiklos@…>]

first, sorry for the slow answer.

second, yes, make clean && make solved the segfault problem.

third, here is what i have atm:

$ bzr diff
=== modified file 'protocols/msn/msn.c'
--- protocols/msn/msn.c 2008-01-06 12:32:27 +0000
+++ protocols/msn/msn.c 2008-01-21 02:30:09 +0000
@@ -337,6 +337,8 @@

 static char *msn_set_display_name( set_t *set, char *value )
 {
+       printf("msn_set_display_name() called\n");
+       fflush(stdout);
        account_t *acc = set->data;
        struct im_connection *ic = acc->ic;
        struct msn_data *md;

when i type 'nick msn vmiklos' i get the 'msn_set_display_name() called' output. but when i type 'set msn/diplay_name vmiklos' i get no output.

if you type set msn/diplay_name foo then you get the output?

(this is now r336)

thanks,

• VMiklos

[VMiklos <vmiklos@…>]

this can be closed, the solution is to use account set instead of set, so it's a pebkac.

though it may worth to add a warning when using set foo/bar

[wilmer]

Ok, we found out that this was a small case of PEBKAC. Fixed in changeset:devel,337 by adding a warning and not using the "nick" command in the online help anymore.