Twitter prefix length not configurable

[anonymous]

The length of prefix/reply ids is hardcoded to be 2, instead of allowing a configurable length - this is probably linked to the hardcoded TWITTER_LOG_LENGTH of 256 as well. Busy timelines don't get proper representation.

[aaron.toponce@…]

While the following patch doesn't address making the hard-coded TWITTER_LOG_LENGTH variable configurable from an end-user perspective, but it does increase it to 65535, which is much more manageable for busy timelines, preventing users from replying to the wrong tweet.

From dfe713d6ec086846ac52db89481ed1d5a4661e35 Mon Sep 17 00:00:00 2001
From: Kristian Fiskerstrand <kf@sumptuouscapital.com>
Date: Wed, 20 Jul 2016 12:31:17 +0200
Subject: [PATCH] (protocols/twitter/twitter.h) increase TWITTER_LOG_LENGTH

By default twitter use a single byte for identifiers, leading to
rollover after 256 messages and me replying to arbitrary messages.
Increasing it to 65536 (it is actually using a signed int so can
be increased even further)
---
 protocols/twitter/twitter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/protocols/twitter/twitter.h b/protocols/twitter/twitter.h
index 5a1a4f6..293e881 100644
--- a/protocols/twitter/twitter.h
+++ b/protocols/twitter/twitter.h
@@ -97,7 +97,7 @@ struct twitter_user_data {
 	time_t last_time;
 };
 
-#define TWITTER_LOG_LENGTH 256
+#define TWITTER_LOG_LENGTH 65536
 struct twitter_log_data {
 	guint64 id;
 	/* DANGER: bu can be a dead pointer. Check it first.
-- 
2.7.3