[PATCH] Implement jabber message receipts (XEP-0184)

[michael+bitlbee@…]

This change will make BitlBee acknowledge messages when requested. It will not request message receipts from other clients, mainly because I am not sure if this feature can be mapped to IRC cleanly.

[wilmer]

Whoa, is this:

char *foo
{
    ...do something with foo...
    char *foo = blah;
    ...then do something else with the new foo...
}

valid C these days? I know C99 allows variable declarations halfway a scope, but I didn't know this was possible.

I've merged this now with a few changes:

jabber_util.c already adds id= attributes to the stanzas that need them (only <iq/> so far) so I've removed that. Also, from= attributes are not required from clients.

So yes, BitlBee currently sends <message/> stanzas without id's. This means that other clients can't possibly ack them, but since it won't request acknowledgements either, this should be okay.

Merged in changeset:devel,940.

[michael+bitlbee@…]

Replying to wilmer:

Whoa, is this:

char *foo
{
    ...do something with foo...
    char *foo = blah;
    ...then do something else with the new foo...
}

valid C these days? I know C99 allows variable declarations halfway a scope, but I didn't know this was possible.

It is valid C89, but adding -Wshadow will make the compiler warn you about shadowing a previous declaration. In fact, I didn’t even notice I did this :-).

Merged in changeset:devel,940.

Thanks for merging! I’m running the new version now and it works in my tests.