Nick generation screws up with invalid characters in nick_format

[anonymous]

As requested by bitlbee itself. :-) It's bitlbee v3 BTW.

It happened after any of these:

&bitlbee# acc 6 set nick_format %nick[$account]
&bitlbee# acc 6 set nick_format %handle[$account]
&bitlbee# acc 6 set nick_format %-@nick[$account]

With the default setting it works fine. :-)

08:22:39 <@bitlbee> FAILED. Returning an insane nick now. Things might break. Good luck, and please don't forget to paste the lines up here in
                    #bitlbee on OFTC or in a mail to wilmer@gaast.net
08:22:39 <@bitlbee> Warning: Almost had an infinite loop in nick_get()! This used to be a fatal BitlBee bug, but we tried to fix it. This message
                    should *never* appear anymore. If it does, please *do* send us a bug report! Please send all the following lines in your report:
08:22:39 <@bitlbee> Trying to get a sane nick for handle TivoliUtrecht
08:22:39 <@bitlbee> Char 0: �/-99
08:22:39 <@bitlbee> Char 1: _/95
08:22:39 <@bitlbee> Char 2: _/95
08:22:39 <@bitlbee> Char 3: _/95
08:22:39 <@bitlbee> Char 4: _/95
08:22:39 <@bitlbee> Char 5: _/95
08:22:39 <@bitlbee> Char 6: _/95
08:22:39 <@bitlbee> Char 7: _/95
08:22:40 <@bitlbee> Char 8: _/95
08:22:40 <@bitlbee> Char 9: _/95
08:22:40 <@bitlbee> Char 10: _/95
08:22:40 <@bitlbee> Char 11: _/95
08:22:40 <@bitlbee> Char 12: _/95
08:22:40 <@bitlbee> Char 13: _/95
08:22:40 <@bitlbee> Char 14: _/95
08:22:40 <@bitlbee> Char 15: _/95
08:22:40 <@bitlbee> Char 16: _/95
08:22:40 <@bitlbee> Char 17: _/95
08:22:40 <@bitlbee> Char 18: _/95
08:22:40 <@bitlbee> Char 19: _/95
08:22:40 <@bitlbee> Char 20: _/95
08:22:40 <@bitlbee> Char 21: _/95
08:22:40 <@bitlbee> Char 22: _/95
08:22:40 <@bitlbee> Char 23:

[harmen@…]

Erh, this was my ticket. :-) Forgot to toss in my name...

[wilmer]

This is definitely a bug, the evaluator for nick_format should fix this by checking for invalid chars (in your case $ instead of %account. In the other ticket (#702) the invalid chars are parentheses.

The only chars allowed in IRC nicks are:

static char *nick_lc_chars = "0123456789abcdefghijklmnopqrstuvwxyz{}^`-_|";
static char *nick_uc_chars = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ[]~`-_\\";

[dx]

Formatting fixes in the description.

Does this bug still make sense? I don't see anything about insane nicks in the current code.

[wilmer]

The error message has been removed yes, since the bug that made me add it is gone for some time by now.

I don't know for sure whether I've fixed handling of invalid char in nick_format. If I did, then this can be closed.

A quick check shows that I did, stuff gets stripped properly now.