Modify

#1196 closed defect (fixed)

[ssi.c:65] possible cut'n'paste error ?

Reported by: dcb314@… Owned by:
Priority: normal Milestone:
Component: BitlBee Version: 3.2.2
Keywords: Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

[ssi.c:65]: (style) Same expression on both sides of '&&'.

if ((cur->gid == newitem->gid) && (cur->gid == newitem->gid))

Maybe better code

if ((cur->bid == newitem->bid) && (cur->gid == newitem->gid))

Attachments (0)

Change History (3)

comment:1 Changed at 2015-02-23T05:35:51Z by dx

Honestly I'd rather not touch this code at all. We've got no one who actually understands this code

Closest I could get to someone who understands it

https://hg.pidgin.im/pidgin/main/rev/b5393db78439#l6.156

It replaces the relevant line with something unrelated. Ehhhh. Whatever.

I really don't know if I want to apply this change and ignore the rest, or close this ticket and not do anything unless someone figures out what real life effect this line could have.

Have I mentioned I don't want to touch this code?

comment:2 Changed at 2015-02-23T08:56:38Z by anonymous

There is some similar code a few lines further down which seems to look much better.

This bug looks like a simple copy'n'paste bug to me.

My suggested change looks reasonably low risk to me.

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.