[ssi.c:65] possible cut'n'paste error ?

[dcb314@…]

[ssi.c:65]: (style) Same expression on both sides of '&&'.

if ((cur->gid == newitem->gid) && (cur->gid == newitem->gid))

Maybe better code

if ((cur->bid == newitem->bid) && (cur->gid == newitem->gid))

[dx]

Honestly I'd rather not touch this code at all. We've got no one who actually understands this code

Closest I could get to someone who understands it

​https://hg.pidgin.im/pidgin/main/rev/b5393db78439#l6.156

It replaces the relevant line with something unrelated. Ehhhh. Whatever.

I really don't know if I want to apply this change and ignore the rest, or close this ticket and not do anything unless someone figures out what real life effect this line could have.

Have I mentioned I don't want to touch this code?

[anonymous]

There is some similar code a few lines further down which seems to look much better.

This bug looks like a simple copy'n'paste bug to me.

My suggested change looks reasonably low risk to me.

[dx]

Applied in ​https://github.com/bitlbee/bitlbee/commit/81a15dab997b9dc3f94d46ebee331cf61fc2e43d