Modify

#896 closed defect (fixed)

Add newlines to debugging output

Reported by: anonymous Owned by:
Priority: minor Milestone:
Component: BitlBee Version: 3.0.4
Keywords: Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

The following changes since commit 8d75aa15f4ae890d13055b97ee42bdd1eb98cb3e:

  Version 3.0.4, probably. (2011-12-04 19:21:06 +0000)

are available in the git repository at:
  https://github.com/sc68cal/Bitlbee topic_debug_print

Sean M. Collins (1):
      Add missing newlines to debug output

 lib/http_client.c  |    2 +-
 protocols/msn/ns.c |    2 +-
 protocols/msn/sb.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/http_client.c b/lib/http_client.c
index 56a6f37..7c24bf1 100644
--- a/lib/http_client.c
+++ b/lib/http_client.c
@@ -462,7 +462,7 @@ cleanup:
 		closesocket( req->fd );
 	
 	if( getenv( "BITLBEE_DEBUG" ) && req )
-		printf( "Finishing HTTP request with status: %s",
+		printf( "Finishing HTTP request with status: %s\n",
 		        req->status_string ? req->status_string : "NULL" );
 	
 	req->func( req );
diff --git a/protocols/msn/ns.c b/protocols/msn/ns.c
index e144a8d..44fc678 100644
--- a/protocols/msn/ns.c
+++ b/protocols/msn/ns.c
@@ -54,7 +54,7 @@ int msn_ns_write( struct im_connection *ic, int fd, const char *fmt, ... )
 		fd = md->ns->fd;
 	
 	if( getenv( "BITLBEE_DEBUG" ) )
-		fprintf( stderr, "->NS%d:%s", fd, out );
+		fprintf( stderr, "->NS%d:%s\n", fd, out );
 	
 	len = strlen( out );
 	st = write( fd, out, len );
diff --git a/protocols/msn/sb.c b/protocols/msn/sb.c
index 37ac288..d36ca1f 100644
--- a/protocols/msn/sb.c
+++ b/protocols/msn/sb.c
@@ -46,7 +46,7 @@ int msn_sb_write( struct msn_switchboard *sb, const char *fmt, ... )
 	va_end( params );
 	
 	if( getenv( "BITLBEE_DEBUG" ) )
-		fprintf( stderr, "->SB%d:%s", sb->fd, out );
+		fprintf( stderr, "->SB%d:%s\n", sb->fd, out );
 	
 	len = strlen( out );
 	st = write( sb->fd, out, len );

Attachments (0)

Change History (2)

comment:1 Changed at 2012-01-11T02:24:27Z by Sean M. Collins <sean@…>

Sorry, did not put my name in the Author field! Direct all inquiries my way.

comment:2 Changed at 2012-02-11T13:02:26Z by wilmer

Resolution: fixed
Status: newclosed

Pushed up to revision 886.

Although I wonder if the two in msn/ already contain newlines. Probably only in the case of simple commands.

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.