Opened at 2011-09-09T17:39:08Z
Closed at 2011-10-21T03:03:03Z
#830 closed defect (fixed)
colored /me (OTR) from IM not converted to CTCP ACTION
| Reported by: | architekt[at]coding4coffee.org | Owned by: | wilmer |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | OTR | Version: | 3.0.3 |
| Keywords: | color, ctcp, action | Cc: | pesco |
| IRC client+version: | Client-independent | Operating System: | Linux |
| OS version/distro: |
Description
If a plugin (for example OTR) colors a message with mIRC color codes, a "/me" isn't converted to a CTCP ACTION anymore, because the check in irc_send_msg() compares the first 4 characters of the message with "/me ", which are now something like "\x0303/me".
I attach a patch where this is fixed in the OTR plugin (which is preferred, I think), and the patch I wrote first that checks the message in irc_send_msg() for (colored)"/me" (some more code, the wrong place (?))
Attachments (2)
Change History (7)
Changed at 2011-09-09T17:40:10Z by
comment:1 follow-up: 2 Changed at 2011-09-30T04:37:04Z by
| Owner: | changed from pesco to wilmer |
|---|---|
| Status: | new → assigned |
took your otr.patch as a starting point and beautified the whole function a bit. thanks!
revision 813 in http://code.khjk.org/bitlbee/, please pull.
comment:2 Changed at 2011-10-03T15:50:11Z by
of course this ticket only applies when the message in question will go to a query window. revision 818 at the above location adds that check.
comment:3 follow-up: 4 Changed at 2011-10-20T03:24:28Z by
| Cc: | pesco added |
|---|
pesco, I think you decided to drop the colours altogether so this bug should be closed?
comment:4 Changed at 2011-10-20T07:48:02Z by
comment:5 Changed at 2011-10-21T03:03:03Z by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed/Merged.
The patch for otr.c