#830 closed defect (fixed)

colored /me (OTR) from IM not converted to CTCP ACTION

Reported by: architekt[at] Owned by: wilmer
Priority: normal Milestone:
Component: OTR Version: 3.0.3
Keywords: color, ctcp, action Cc: pesco
IRC client+version: Client-independent Operating System: Linux
OS version/distro:


If a plugin (for example OTR) colors a message with mIRC color codes, a "/me" isn't converted to a CTCP ACTION anymore, because the check in irc_send_msg() compares the first 4 characters of the message with "/me ", which are now something like "\x0303/me".

I attach a patch where this is fixed in the OTR plugin (which is preferred, I think), and the patch I wrote first that checks the message in irc_send_msg() for (colored)"/me" (some more code, the wrong place (?))

Attachments (2)

otr.patch (937 bytes) - added by architekt[at] at 2011-09-09T17:40:10Z.
The patch for otr.c
irc_send_msg.patch (4.3 KB) - added by architekt[at] at 2011-09-09T17:41:11Z.
The patch for irc_send.c

Download all attachments as: .zip

Change History (7)

Changed at 2011-09-09T17:40:10Z by architekt[at]

Attachment: otr.patch added

The patch for otr.c

Changed at 2011-09-09T17:41:11Z by architekt[at]

Attachment: irc_send_msg.patch added

The patch for irc_send.c

comment:1 Changed at 2011-09-30T04:37:04Z by pesco

Owner: changed from pesco to wilmer
Status: newassigned

took your otr.patch as a starting point and beautified the whole function a bit. thanks!

revision 813 in, please pull.

comment:2 in reply to:  1 Changed at 2011-10-03T15:50:11Z by pesco

of course this ticket only applies when the message in question will go to a query window. revision 818 at the above location adds that check.

comment:3 Changed at 2011-10-20T03:24:28Z by wilmer

Cc: pesco added

pesco, I think you decided to drop the colours altogether so this bug should be closed?

comment:4 in reply to:  3 Changed at 2011-10-20T07:48:02Z by pesco

Replying to wilmer:

pesco, I think you decided to drop the colours altogether so this bug should be closed?

um no, i decided to strip all except these refered to here. cf. #835.

comment:5 Changed at 2011-10-21T03:03:03Z by wilmer

Resolution: fixed
Status: assignedclosed


Modify Ticket

as closed The owner will remain wilmer.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.