Oscar module fails to produce outgoing Unicode messages

[dalias]

The oscar module handles character encoding for outgoing messages by first trying to convert the message to Latin-1 (ISO-8859-1) and only attempts to convert to UCS-2 if the first conversion fails. Presumably, the idea is that the first conversion should fail if the message is not faithfully representable in Latin-1, triggering the fallback.

The problem is that the do_iconv function does not treat the inability to represent characters in the target encoding as a failure. do_iconv only fails when iconv_open or iconv returns -1, which would indicate invalid charset, encoding errors in the input string, insufficient space for conversion, etc. - but not failure to represent characters in the destination charset, which is indicated by a positive return value from iconv.

I have attached a patch, but before applying it, some care should be taken to ensure that this doesn't break other code using do_iconv.

[wilmer]

changeset:devel,800.

Thank you!