Opened at 2010-11-22T02:32:19Z
Closed at 2014-03-01T02:11:59Z
#725 closed defect (fixed)
Changes for build on Fedora/Red Hat distro
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | BitlBee | Version: | 3.0 |
| Keywords: | patch | Cc: | |
| IRC client+version: | Client-independent | Operating System: | Public server |
| OS version/distro: |
Description
There are two patches to this bug:
- Use systemlibdirs which are compatible with multilib systems (mainly Fedora family)
- Use install -p instead of install whenever possible (configurable, so it can be easily configured otherwise). Fedora Packaging Guidelines are quite annal retentive about changing dates of files needlessly.
Attachments (3)
Change History (12)
Changed at 2010-11-22T02:32:43Z by
| Attachment: | bitlbee-syslibdirs.patch added |
|---|
Changed at 2010-11-22T02:32:58Z by
| Attachment: | bitlbee-installP.patch added |
|---|
Use install -p instead of install
comment:1 Changed at 2010-11-22T10:42:27Z by
install -p is supported by all sane versions of the install command, I guess? It is listed on http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man1/install.1.html at least.
comment:2 Changed at 2014-02-04T06:23:02Z by
| Keywords: | patch added |
|---|
comment:3 Changed at 2014-02-04T11:56:01Z by
Damn Solaris and their so-called Unix utilities, http://www.unix.com/man-page/All/1/install/ shows that again OpenSolaris is the only Unix not having -p for install(1).
comment:4 follow-up: 5 Changed at 2014-02-04T18:51:33Z by
That ping was more effective than intended!
This version of install (/usr/sbin/install) is not compatible with the install binaries in many versions of Unix other than Solaris. For a higher degree of compatibility with other Unix versions, use /usr/ucb/install, which is described in the install(1B) man page
They are probably used to this kind of bullshit when installing stuff.
Also, I just checked the source code, and apparently these patches are already merged:
http://code.bitlbee.org/lh/bitlbee/revision/909
See ticket #956, which also has two other patches that wilmer rejected. You might be interested in those.
Also, $(INSTALL) is not being used in the main makefile, only in the docs / user-guide ones, and that's silly.
comment:5 follow-up: 6 Changed at 2014-02-04T22:47:39Z by
Replying to dx:
This version of install (/usr/sbin/install) is not compatible with the install binaries in many versions of Unix other than Solaris. For a higher degree of compatibility with other Unix versions, use /usr/ucb/install, which is described in the install(1B) man page
They are probably used to this kind of bullshit when installing stuff.
For the sad soul who is afflicted with Solaris, you can save yourself (partially) by editing Makefile.settings after running ./configure to replace particular line to have
INSTALL=/usr/usb/install -p
comment:6 Changed at 2014-02-04T23:01:02Z by
Replying to Matej Cepl <mcepl@…>:
INSTALL=/usr/usb/install -p
Damn, that should be /usr/ucb/install -p of course.
comment:7 Changed at 2014-02-04T23:48:25Z by
This is weird ... it seems like part of the installP patch has been accepted (so there is INSTALL=install -p line in configure), but the rest is not (so $(INSTALL) is actually never used.
comment:8 Changed at 2014-02-04T23:52:24Z by
Look at your patch, now back at revision 909, now back at your patch. Sadl^H^H^H^H^H *cough*. You forgot to include a patch for the main makefile.
Changed at 2014-02-04T23:59:02Z by
| Attachment: | bitlbee-3.2-install.patch added |
|---|
Use install -p instead of install
comment:9 Changed at 2014-03-01T02:11:59Z by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Last patch applied in r1012, thanks!
Use sane value of systemlibdirs