Opened at 2010-11-04T11:24:31Z
Closed at 2015-08-11T06:53:19Z
#710 closed defect (fixed)
Multi-Line messages in OTR, text colour
Reported by: | Owned by: | pesco | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | OTR | Version: | 3.0 |
Keywords: | Cc: | ||
IRC client+version: | Client-independent | Operating System: | Public server |
OS version/distro: |
Description
I'm using developer revision 714 of the bitlbee libpurple Debian package.
I am talking to somebody using Pidgin with OTR.
When they send me a message, the text is green to say it is encrypted. If they send me a multi-line message, only the first line is green and the subsequent lines are in black text.
Attachments (0)
Change History (3)
comment:1 follow-up: 2 Changed at 2011-07-29T07:59:15Z by
Component: | BitlBee → OTR |
---|---|
Owner: | set to pesco |
Priority: | normal → minor |
Status: | new → accepted |
comment:2 Changed at 2011-10-03T17:34:10Z by
i see i misunderstood. we do break messages, either if lines are too long or they include explicit linebreaks. in that case irc_send_msg
(irc_send.c
) sends off multiple PRIVMSG
s. so maybe we should indeed try to place the color code at the beginning of each line. note: the otr-encrypted channel always carries HTML. so we need to look for <br>
. additionally, if i read the code of strip_html
(lib/misc.c
) correctly, we are not removing newline ('\n'
) characters from the incoming messages, so we must treat those as linebreaks as well.
comment:3 Changed at 2015-08-11T06:53:19Z by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
i think this is an issue on the side of the IRC client, as we don't break the lines. we just send the color code once at the start of the message and there's not much more we can do, AFAICS.