bzr rev >= #643 fails to build

[Christian Ebert <blacktrash@…>]

Since bzr #643 making bitlbee fails with:

proxy.c: In function ‘proxy_connect_none’: proxy.c:106: error: ‘AI_NUMERICSERV’ undeclared (first use in this function) proxy.c:106: error: (Each undeclared identifier is reported only once proxy.c:106: error: for each function it appears in.) make[1]: * [proxy.o] Error 1 make: * [lib] Error 2

$ sw_vers ProductName: Mac OS X ProductVersion: 10.5.8 BuildVersion: 9L30

Configure params:

--pidfile=/usr/local/var/run/bitlbee/bitlbee.pid \ --config=/usr/local/var/lib/bitlbee \ --ipcsocket=/usr/local/var/run/bitlbee/bitlbee.sock --ssl=gnutls

Let me know if you need more info.

[Wilmer van der Gaast <wilmer@…>]

Huh, this is odd.

According to the OS X manpage for getaddrinfo(): ​http://developer.apple.com/mac/library/documentation/Darwin/Reference/ManPages/man3/getaddrinfo.3.html

AI_NUMERICSERV is definitely supported. Could you please do a recursive grep for that and see if maybe misc.c is missing one of the three includes also listed in the man page?

[Wilmer van der Gaast <wilmer@…>]

Instead of misc.c, I obviously meant proxy.c.

[Christian Ebert <blacktrash@…>]

Replying to Wilmer van der Gaast <wilmer@…>:

According to the OS X manpage for getaddrinfo(): ​http://developer.apple.com/mac/library/documentation/Darwin/Reference/ManPages/man3/getaddrinfo.3.html

But that's the man page for MacOS 10.6.3 (Snow Leopard); I'm on 10.5.8.

AI_NUMERICSERV is definitely supported. Could you please do a recursive grep for that and see if maybe misc.c is missing one of the three includes also listed in the man page?

On 10.5.8 man 3 getaddrinfo only mentions AI_NUMERICHOST:

​http://developer.apple.com/mac/library/documentation/Darwin/Reference/ManPages/10.5/man3/getaddrinfo.3.html?useVersion=10.5

[Wilmer van der Gaast <wilmer@…>]

Oh damn it :-( That's indeed a surprisingly recent addition then.

Can you try removing it and see if things still work?

[Christian Ebert <blacktrash@…>]

Replying to Wilmer van der Gaast <wilmer@…>:

Oh damn it :-( That's indeed a surprisingly recent addition then.

Can you try removing it and see if things still work?

Builds fine then. I don't have much time to use bitlbee atm. What would be a testcase? At a first glance everything works.

thx for looking into this btw.

[Wilmer van der Gaast <wilmer@…>]

No problem, I'm glad you reported this before it got into a release. If this successfully connects to *any* IM protocol, that's enough success for me. Just want to make sure that getaddrinfo() still accepts numeric services without NUMERICSERV.

[Christian Ebert <blacktrash@…>]

Replying to Wilmer van der Gaast <wilmer@…>:

No problem, I'm glad you reported this before it got into a release. If this successfully connects to *any* IM protocol, that's enough success for me. Just want to make sure that getaddrinfo() still accepts numeric services without NUMERICSERV.

I don't use twitter or irc atm. So I can only confirm jabber, msn, and oscar.

[Wilmer van der Gaast <wilmer@…>]

That's a great list already. :-) No worries, if one of them works, I'm very sure they all do. I'll fix this in head some day soon. Thanks for your report!

[wilmer]

Oh yes, this was fixed by changeset:devel,655.