Modify

#647 closed enhancement (fixed)

GMail new mail notification

Reported by: krisfremen Owned by: wilmer
Priority: wishlist Milestone:
Component: Jabber Version: devel
Keywords: patch Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

It would be nice if this was somehow incorporated into the jabber protocol. To have google notify you somehow of new messages.

I would actually prefer this to _not_ be in the main channel and sent from a contact.

Wilmer said he could probably integrate this if he he an xmpp extension. After a little googling, I came up with http://code.google.com/apis/talk/jep_extensions/gmail.html#notifications

And as wilmer suggested, here I am, filing a ticket :)

Attachments (3)

bitlbee-3.0.3-gmail_notify.patch (7.7 KB) - added by Artem Savkov <artem.savkov@…> at 2011-08-07T18:59:59Z.
bitlbee-bzr871-gmail_notify.patch (7.7 KB) - added by Artem Savkov <artem.savkov@…> at 2012-01-18T14:43:12Z.
bitlbee-bzr945-gmail_notify.patch (15.4 KB) - added by Artem Savkov <artem.savkov@…> at 2012-11-21T08:27:46Z.

Download all attachments as: .zip

Change History (13)

comment:1 Changed at 2010-07-16T12:19:54Z by thedeppchef@…

I would welcome that addition very much :)

comment:2 Changed at 2011-08-07T18:59:43Z by Artem Savkov <artem.savkov@…>

I took a shot at this and here is what I came up with. Messages are handled same as with xmlconsole, there is also a "gmail_notify" account setting wich is similar to xmlconsole (not documented yet). Tested on 3.0.3 and bzr803, and everything seems to work, at least for single gmail account, haven't tested with multiple accs.

Wilmer, can you please take a look at the patch and tell me what can/should be improved in it? Hope this is more of a help than a hassle.

Changed at 2011-08-07T18:59:59Z by Artem Savkov <artem.savkov@…>

comment:3 Changed at 2011-08-27T10:35:41Z by wilmer

Hello and sorry for the delay again - I'm not spending as much time on BitlBee this year like last.

The patch is pretty neat actually, from a quick glance! I think I'll rename the setting to mail_notifications though, since that's how it's called on MSN and Yahoo! as well. It's true that it's GMail-specific here but actually it's the same on MSN since there it only works for active live/hotmail accounts.

I'll take a look at this and your other patch and get them merged pretty soon. I'll let you know if I have any further comments. Thanks!

comment:4 Changed at 2011-10-21T04:22:47Z by wilmer

Looking at this again now.

So far IM modules report new e-mails in the control channel, I assume you're using a separate contact for it so that the notifications appear in a query window instead and draw more attention? This idea is interesting, although in my case if I'd use them I would keep them in the control channel.

This sounds like something that should be configurable. :-) And in that case we need to unify these a little bit. What if I create a imcb_notify_email() callback or something like that, and depending on a user setting the notification will go to the right place?

And oh yes, this is definitely more a help than a hassle. Thanks for the patch - I think it mostly looks good already. :-)

comment:5 Changed at 2011-10-21T12:32:35Z by Artem Savkov <artem.savkov@…>

Yes, the idea was to draw more attention, since gmail makes it easy to get notifications only about important messages by sending notifications only on new emails in inbox(i.e. not archived). I always vote for flexibility, and your idea sounds really great. Let me know if I can be of further assistance here.

Changed at 2012-01-18T14:43:12Z by Artem Savkov <artem.savkov@…>

comment:6 Changed at 2012-01-18T14:43:41Z by Artem Savkov <artem.savkov@…>

Same code rebased to work with current bzr.

Changed at 2012-11-21T08:27:46Z by Artem Savkov <artem.savkov@…>

comment:7 Changed at 2012-11-21T08:30:35Z by Artem Savkov <artem.savkov@…>

Patch with imcb_notify_email() and notify_handle set option for all email-notification enabled protocols. I see that wanting this notifications as queries is highly subjective so if you'd like I can drop a patch with imcb_log instead.

comment:8 Changed at 2014-02-04T06:43:32Z by dx

Keywords: patch added

comment:9 Changed at 2014-06-02T14:06:12Z by moo.bitlbee.z.edmcman@…

I'd love to see this merged, and I have some free cycles. Is there anything I can do?

comment:10 Changed at 2015-10-13T06:01:24Z by dx

Resolution: fixed
Status: newclosed

This got merged at some point before 3.4.1

Modify Ticket

Action
as closed The owner will remain wilmer.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.