Modify

#577 closed enhancement (fixed)

patch: persistent channel names for groupchats

Reported by: vmiklos@… Owned by:
Priority: normal Milestone:
Component: BitlBee Version: 1.2.5
Keywords: Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

Hi,

Here is a patch that makes it possible to pass a 3rd parameter to imcb_chat_new() so that the chat won't be named &chat_<id> but something else. This can be handy in case a named skype group chat or jabber conference has a persitent name and the irc client config would like to refer to that window, ie: "always put conference@… to window 9 in irssi".

The first part changes bitlbee and fixes up the builtin protocols to behave like they did perviously. The second part is the skype plugin part which demonstrates how a plugin could make use of this feature.

http://frugalware.org/~vmiklos/patches/bitlbee-persistent-channames.patch

http://frugalware.org/~vmiklos/patches/bitlbee-skype-persistent-channames.patch

The idea is that there is already a "handle" for the groupchat, and in case the plugin _knows_ that the handle is a valid irc channel name as well (not counting the & prefix), then we can have persistent channel names without introducing a new member in the groupchat struct.

Attachments (0)

Change History (5)

comment:1 Changed at 2010-03-19T22:40:25Z by lkraav <leho@…>

following, hopefully this will put me on the cc list

comment:2 Changed at 2010-03-28T12:27:51Z by wilmer

BTW, I was thinking about this: What if I slightly adapt this to introduce a imcb_chat_name_hint() function or so, to be more consistent with what I did for buddies?

It'll also allow you to give the channel a name that isn't necessarily derived from the IM-internal name.

comment:3 Changed at 2010-03-28T14:08:55Z by vmiklos@…

I'm fine with that.

comment:4 Changed at 2010-04-09T00:45:18Z by wilmer

Resolution: fixed
Status: newclosed

changeset:devel,539.

No changes required to the old modules this way. Just call the function before adding the user and it'll work. (Once the user's joined the info will be ignored as renaming IRC channels is more or less impossible.)

comment:5 Changed at 2010-04-14T00:26:09Z by vmiklos@…

Just for the reference, if you build the just released bitlbee-skype-0.8.2 against bitlbee bzr, then it'll make use of this feature. :)

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.