Long AIM profiles get chopped

[f0rked]

Long lines in AIM profiles will get chopped off if they are 'too long'.

[jbms]

I have experienced the problem of the entire profile text being chopped; perhaps this is what the user that posted this bug report really meant. I also found a solution to the problem I was experiencing.

The truncation was due to the fixed buffer lengths specified in serv_got_crap' defined in protocols/nogaim.c. I simply increased the buffer lengths (for the text' and `buf' buffers) to 8192 bytes from 1024 bytes, and then changed the parameter to do_iconv to 8192 as well. It might be better to fix this problem by not using fixed-length buffers, but this solution has worked okay so far, as I have not yet come across a profile that exceeds that length. I think that 1024 bytes is certainly too short though, so this change should probably be made if the code isn't going to be fixed to not use fixed lengths.

[anonymous]

Yes, increasing the buffer size a little bit is the easy fix, but I'm looking for something better (as-in something that wastes less memory). :-)

[wilmer]

Argh, forgot to log in...

So anyway, not really an OSCAR bug.

[jbms]

Note that it is a buffer on the stack, so the memory isn't in use for very long. It is probably better not to use fixed-size buffers in any case though.

[TayleeFaye248@…]

Can i please have a longer profile =)