bitlbee sends invalid IRC messages by failing to remove whitespace from screen names

[nwf@…]

Tested on Bitlbee 1.2 (Debian unstable 1.2-4) using OSCAR; client is "irssi 0.8.12 (20071006 0939)". I've a number of buddies whose chosen formatting of their screen names involves spaces; bitlbee simply copies these strings into the IRC messages, which violates the protocol (RFC 2812 section 2.3.1; nickname is not allowed to contain spaces).

The upshot of all this is that irssi pukes things like the following into its control window: 11:56 [localhost] -!- Xxx Xx xx414@oscar JOIN :&bitlbee 11:56 [localhost] -!- Xxxxxx@oscar JOIN :&bitlbee 11:56 [localhost] -!- xxxxxxx10@oscar JOIN :&bitlbee 11:57 [localhost] -!- xxxxxxx10@oscar PRIVMSG xxx : ... where the displayed parts of the names are everything after the first space in the screen name's formatted form. (the reason irssi is getting confused is that it's trying to interpret the next chunk of characters as the IRC opcode; this suggests a somewhat interesting annoyance tactic to users known to be running bitlbee by synthesizing IRC events.)

Bitlbee should canonicalize screen names (as it does with aliases) and if necessary maintain an internal mapping back. (I believe, on OSCAR, that such a map is unnecessary and that simply removing spaces suffices. I don't know about other protocols.)

[wilmer]

Yep, I also saw this a little while ago. I'm quite surprised that it took six years for this to show up!

[wilmer]

Fixed in changeset:devel,394.

Just blindly killing all spaces before sending screennames from OSCAR to BitlBee.