Modify ↓

Opened at 2008-03-29T23:44:42Z

Closed at 2008-03-30T21:35:23Z

#384 closed defect (fixed)

Don't re-create the iconv "object" all the time

Reported by: wilmer Owned by:
Priority: normal Milestone: 1.2.1
Component: BitlBee Version: 1.2
Keywords: Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

Every time a string has to be converted (when sending/receiving stuff from IRC), do_iconv() creates a new GIConv structure. It'd probably be more efficient to keep two GIConvs around in irc_t and only recreate them when the user changes the charset setting.

Plus, I see regular crashes on creating this object. I'm not sure if this is really a bug in iconv/its GLib hooks, maybe BitlBee *is* somehow hitting it in a weak spot by running g_iconv_new() so often.

This maybe less trivial than it seems. If so, I'll update the milestone...

Attachments (0)

Change History (1)

comment:1 Changed at 2008-03-30T21:35:23Z by wilmer

Resolution: → fixed
Status: new → closed

Hah, so it wasn't that hard. :-)

changeset:devel,370

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.