/away "status message" not set on XMPP

[digitalcircuit]

Issue

As of BitlBee 3.5.1+20170406+master+10-g0515063-git, setting away status for XMPP accounts does not include the away message.

This worked several months ago; unfortunately I'm not sure exactly when.

Test case

account jabber set away "Message"

Verify via another Jabber account that it is set away and has the status message Message.

Currently, Bitlbee incorrectly only sets away state, not the actual message, as verified by _xmlconsole.

account jabber set -del away

Verify via another Jabber account that it is no longer away.

Conversation from #bitlbee

<digitalcircuit> dx: What XEP does Bitlbee use to set /away Some message here?  It's not working on my Prosody setup and I'm trying to find what module to enable.
<dx> pretty sure that's core stuff
<dx> https://xmpp.org/rfcs/rfc3921.html#rfc.section.2.2.2.2
<digitalcircuit> Any idea what might break it?
<digitalcircuit> It sets Away, but the message doesn't show up.
<dx> dunno, have you verified that they are sent with xmlconsole?
<digitalcircuit> https://github.com/bitlbee/bitlbee/blob/7801298f6a855cda0c62433d45ec717d2773ef73/doc/user-guide/commands.xml#L1816 doesn't align with https://wiki.bitlbee.org/Debugging , might want to update the former to mention "_xmlconsole" instead of "xmlconsole"...
<digitalcircuit> <_xmlconsole> TX: <presence><priority>25</priority><show>away</show><c xmlns="http://jabber.org/protocol/caps" node="http://bitlbee.org/xmpp/caps" ver="3.5.1+20170406+master+10-g0515063-git"/></presence>
<digitalcircuit> Nope, no mention of the message.
<digitalcircuit> Huh, it's broken with DukGo, too, and I -know- it worked there before.
<digitalcircuit> dx: Last known working was.. a few months ago?
<dx> hmmmmm
<digitalcircuit> Does it work on your machine?
<dx> nope

Some messages trimmed

[digitalcircuit]

A run of git bisect points to this commit: ac68733ad7a5127395d6367b655a2d9de5d911b5

sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect start
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect good 3.2
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect bad 3.4.2
Bisecting: 175 revisions left to test after this (roughly 8 steps)
[9740ce9c9f432788e88f789e517058139f69bdda] Add python script to generate help.txt, replacing xslt stuff
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect skip
Bisecting: 175 revisions left to test after this (roughly 8 steps)
[11e42dcf7366ee547b9651648724d35d12e36091] msn: removed switchboards, implemented SDG message
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect skip
Bisecting: 175 revisions left to test after this (roughly 8 steps)
[25f6151ce38d07cd85f68c3e881acdf8652f6dc1] set_eval_channel_type: skip the channel free/init if nothing is changed
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect good
Bisecting: 17 revisions left to test after this (roughly 4 steps)
[ea39049f995fb01987a3556520639fefb3bb79a7] ini: Null check file parameter before passing it to open()
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect bad
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[ed431c389887080dc4fa45e30d051ce733f4ce57] imc_away_send_update: Fix leak of away_states linked list
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect bad
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[03df717bf8e01754c730c3ab5e08ed6a920dcb40] Add 'log' UI function, to avoid direct calls to irc_rootmsg from nogaim
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect good
Bisecting: 2 revisions left to test after this (roughly 1 step)
[48b5fef4553ff38711bbdf1773b13841cf0f13c3] purple: assume HTML for all protocols, fixes random <> for some
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect good
Bisecting: 1 revision left to test after this (roughly 1 step)
[9b02bab9832308cf88d86a379b3afd2f142816e2] Remove facebook XMPP code, show error pointing at the new plugin
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[ac68733ad7a5127395d6367b655a2d9de5d911b5] If imc_away_state_find() fails, try again finding "away"
sly@kyuubi-desktop:~/Source/Chat/Bitlbee/bitlbee$ git bisect bad
ac68733ad7a5127395d6367b655a2d9de5d911b5 is the first bad commit
commit ac68733ad7a5127395d6367b655a2d9de5d911b5
Author: dequis <dx@[email removed]>
Date:   Sat Dec 5 12:53:02 2015 -0300

    If imc_away_state_find() fails, try again finding "away"
    
    Fixes trac ticket 1175, https://bugs.bitlbee.org/bitlbee/ticket/1175
    "Setting away with libpurple fails silently except for a few values"
    
    Turns out the fallback was the first item of the list, which for
    libpurple's jabber is "Feeling" (what?) and seems to be a no-op in
    practice.
    
    With this commit the fallbacks are in this order:
    
    1. Try to find whatever the user wrote in the away setting.
    2. If that fails, find "away" in the away states.
    3. If that fails, use the first away state.
    
    This might not fix it in some rare cases where the prpl doesn't have
    an away state equivalent to away. But hopefully the old fallback works
    for those, jabber was the weird one here.

:040000 040000 f5a3f071c2dfdbcfe1cc7ffd97c3555fd5066a3f 4e168c85340d0ee184730714df2530f156f5d800 M	protocols

[dx]

Forgot to close this, was fixed by eb73d05e00156afd5ea6d7819d0d7ef2ccadedde