[PATCH] twitter: maintain mentions when replying

[jhl <james-bitlbee-trac@…>]

At present, when you reply to a tweet, that tweet's author is @mentioned in the reply. This is unintuitive in two cases:

1. When you reply to a tweet that mentioned multiple people, those mentions are not carried over, breaking the thread.

2. When you reply to one of your own replies, the new reply gets @yourself at the beginning, so the intended recipient won't be notified.

The attached patch addresses this by introducing function twitter_format_reply, which looks at the original message being replied to to create the mention list at the beginning. This is composed as:

1. the original message author (if not us),
2. any mentions at the start of the original message, except us or the original author

Mentions are assumed to be space-separated words starting with @; as soon as a non-space, non-@ character is found parsing stops.

To support this, the text of each tweet is stored in the twitter_log_data struct.

[jhl <james-bitlbee-trac@…>]

Oops, sorry - forgot to set the enhancement label!

[dx]

For some reason I can't access that attachment, please use pull requests instead ​https://github.com/bitlbee/bitlbee/pulls