Modify ↓

Opened at 2016-08-24T05:55:18Z

Closed at 2016-12-26T23:13:12Z

#1263 closed defect (fixed)

Duplicate messages in jabber conference group chats.

Reported by: benc Owned by:
Priority: normal Milestone:
Component: Jabber Version: 3.4.2
Keywords: Cc:
IRC client+version: irssi 0.8.19 (20160323 0008) Operating System: Linux
OS version/distro: Debian stretch(testing)

Description

I consistently get duplicate messages when I comment in groupchat using the jabber/xmpp protocol to connect to a slack.com group. It appears that both the sent and received messages are printed.

The xml_console debug looks like this: 

09:38 <_xmlconsole> TX: <message type="groupchat" to="testroom@conference.company.xmpp.slack.com"  
                    id="BeeCYIcjJguxIISSBeBn"><body>test</body></message> 
09:38 <_xmlconsole> RX: <message xmlns="jabber:client" from="testroom@conference.company.xmpp.slack.com/userx"  
                    to="userx@company.xmpp.slack.com/BitlBee" type="groupchat"  
                    ts="1471995489.000006"><body>test</body></message>

This bug may be related to one previously fixed in 2008: 

commit 63075d7345355dde6e490ad00a886a1b165dbe17
Author: Wilmer van der Gaast <wilmer@gaast.net>
Date:   Sun Feb 3 23:33:18 2008 +0000

    Messages from the user are also included in backlogs when joining a Jabber
    chatroom. Until now they were ignored, which might make backlogs a little
    bit confusing.

Attachments (0)

Change History (3)

comment:1 Changed at 2016-08-24T06:17:50Z by dx

It's slack removing the id="..." attribute that is in the outgoing message when it echoes the message back. All XMPP servers echo messages back, slack just happens to do it without that attribute, which we need for deduplication. Since it doesn't have that, it looks like a new message. Other deduplication methods are possible but they generally suck. Sadly it will have to be done.

As a workaround, just use the slack irc gateway instead of xmpp.

This bug may be related to one previously fixed in 2008

MISS! Not even close. Better luck next time!

comment:2 Changed at 2016-08-24T06:38:19Z by benc <benc@…>

Thanks for your help. I'm off to try the slack irc gateway then...

comment:3 Changed at 2016-12-26T23:13:12Z by dx

Resolution: → fixed
Status: new → closed

Workaround attempt in ​a04705b

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.