Opened at 2014-07-20T11:29:08Z
Closed at 2018-04-29T23:50:39Z
#1169 closed enhancement (obsolete)
[patch] Skype protocol: DISPLAYNAME
Reported by: | Owned by: | Miklos Vajna | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Skype | Version: | 3.2.2 |
Keywords: | patch | Cc: | |
IRC client+version: | Client-independent | Operating System: | Linux |
OS version/distro: |
Description
This is a patch providing a bit of new functionality but also fixing one particular bug (see bellow). I've decided to file this together as "enhancement".
If one renames skype contact in skype client (to keep the name with skype so it's centralized), this information is not read by BitlBee and hence can't be used for nick names.
Here I provide a patch with following functionality:
- read DISPLAYNAME which corresponds to the name you've attached to your skype contact manually through skype client
- Display Name is available through "info" command
- Display Name (if specified) takes precedence over Full Name and is passed on in place of Full Name, so nick_format = %full_name will get you Display Name with Full Name as a fallback
- fix bug which caused only offline contacts to receive correct %full_name-based nick names
Patch can be found also at <https://github.com/mkoskar/pkgbuilds/tree/master/bitlbee-skype-displayname-patch>.
Attachments (1)
Change History (5)
Changed at 2014-07-20T11:30:01Z by
Attachment: | skype-displayname.patch added |
---|
comment:1 Changed at 2014-07-20T15:28:02Z by
Keywords: | patch added |
---|
comment:2 Changed at 2014-07-24T23:15:14Z by
URL in the ticket description is obsoleted (404) by <https://github.com/mkoskar/pkgbuilds/tree/master/bitlbee-mkoskar>.
comment:3 Changed at 2014-09-30T09:27:37Z by
Looks reasonable -- could you please add a testcase for your change? See http://code.bitlbee.org/lh/bitlbee/view/head:/protocols/skype/HACKING#L21 for detailed instructions on how to add a testcase.
Thanks! :-)
comment:4 Changed at 2018-04-29T23:50:39Z by
Resolution: | → obsolete |
---|---|
Status: | new → closed |
Closing all skype tickets (plugin removed in a949b43ed657154d4ff8492bbdb16202a1a9f22d)
Neat.