nick_format broken on NetBSD (g_convert_with_fallback() always fails)

[harlos]

NetBSD's implementation of iconv does not appear to support //TRANSLIT. This means g_convert_with_fallback() called with //TRANSLIT will always fail.

With "acc fb set nick_format %full_name" this silently fails and the normal handles are used as if nick_format was never set.

With "acc fb set nick_format fb-%full_name" the failure is more significant as nick_gen() produces "fb-" for all contacts and then the nicks are padded with underscores.

Example (redacted columns):

10:05 <@harlos> blist
10:05 <@root> Nick
10:05 <@root> _________
10:05 <@root> fb-__
10:05 <@root> fb-_____________
10:05 <@root> l_______________

I think there are two solutions:

1. Use gnu iconv on NetBSD
2. Don't use //TRANSLIT for NetBSD (This is what attached path does)

[dx]

Giving up completely on nick translation is definitely not desirable. What's the resulting nick when the warning is thrown?

(Also the last patch has indentation issues)

[harlos]

Below is the first column of the "blist". This occurs because nick_gen() returns "fb-" for all users when the nick_format is set to "fb-%full_name". nick_gen() does not totally fail and return NULL as I would expect. This is because the "fb-" portion is still generated.

21:32 <@harlos> blist
21:32 <@root> Nick             
21:32 <@root> __________       
21:32 <@root> _______________  
21:32 <@root> ________________ 
21:32 <@root> e_______________ 
21:32 <@root> fb-____          
21:32 <@root> fb-_________     
21:32 <@root> kb-_____________ 

[dx]

patch patch patch

[dx]

fixing formatting of description.

[dx]

Merged in ​https://github.com/bitlbee/bitlbee/commit/3a27896e4c1106ed6f48bce3d41ac4c4aa330a46 with a few minor changes

Thanks! And sorry for the delay. I only got around to test a netbsd box a few days ago.