#1112 closed defect

Control interface thinks that I want to accept GTalk contact request when I don't. — at Version 4

Reported by: Burrito Owned by:
Priority: normal Milestone:
Component: BitlBee Version: 3.2
Keywords: patch Cc:
IRC client+version: Client-independent Operating System: Linux
OS version/distro: Raspberry Pi, RaspBMC

Description (last modified by dx)

012 [05:34:31] <@root> gmail - New request: The user [spammer name redacted]@gmail.com wants to add you to his/her buddy list. 012 [05:34:31] <@root> You can use the yes/no commands to accept/reject this request. 012 [05:37:00] <@Burrito> no 012 [05:37:00] <@root> gmail - Rejected: The user [spammer name redacted]@gmail.com wants to add you to his/her buddy list. 012 [05:37:01] <@root> gmail - [spammer name redacted]@gmail.com just accepted your authorization request 012 [05:37:01] 19━━▶ Joins: [spammer name redacted] ([spammer name redacted]@gmail.com) 012 [05:37:08] <@Burrito> no I didn't :(

Change History (5)

comment:1 Changed at 2014-01-12T05:51:38Z by Burrito

Dammit, it didn't see my line breaks. Here is a more formal message:

012 [05:34:31] <@root> gmail - New request: The user [spammer name redacted]@gmail.com wants to add you to his/her buddy list.

012 [05:34:31] <@root> You can use the yes/no commands to accept/reject this request.

012 [05:37:00] <@Burrito> no 012 [05:37:00] <@root> gmail - Rejected: The user [spammer name redacted]@gmail.com wants to add you to his/her buddy list.

012 [05:37:01] <@root> gmail - [spammer name redacted]@gmail.com just accepted your authorization request

012 [05:37:01] 19━━▶ Joins: [spammer name redacted] ([spammer name redacted]@gmail.com)

012 [05:37:08] <@Burrito> no I didn't :(

What I expected to happen there was the user never to be added to my contacts list in the first place.

comment:2 in reply to:  1 Changed at 2014-01-12T05:52:41Z by Burrito

Replying to Burrito:

Sorry, I missed out another line break. Should be obvious; after where I said "no".

comment:3 Changed at 2014-01-17T20:24:17Z by kevin8t8

It looks like this is a simple fix. In protocols/jabber/jabber_util.c, jabber_buddy_ask_no() should be sending "unsubscribed" presence back, not "subscribed".

Changed at 2014-01-17T20:24:39Z by kevin8t8

Attachment: presence-fix.patch added

comment:4 Changed at 2014-02-04T04:36:56Z by dx

Description: modified (diff)
Keywords: patch added
Note: See TracTickets for help on using tickets.