Custom Query (1098 matches)

set FD_CLOEXEC on listening socket

Skype4Py uses os.execlp() to spawn skype if it is not yet started, this leaks our listening FD to skype process and can't get it back even if we ourself exit meanwhile.

and we can't startup again: error: [Errno 98] Address already in use

patch: ​http://cvs.pld-linux.org/packages/bitlbee/skyped-FD_CLOEXEC.patch

seems if skyped/bitlbee-skype sends GET GROUP xxx USERS command, that queues up all other commands and the command itself timeouts.

i sent SEARCH GROUPS CUSTOM manually via skypeconsole to reproduce this:

2012-04-15 14:34:33: >> SEARCH GROUPS CUSTOM
2012-04-15 14:34:33: << GROUPS 
2012-04-15 14:34:47: >> SEARCH GROUPS CUSTOM
2012-04-15 14:34:47: << GROUPS 
2012-04-15 14:34:49: << GROUP 1162 EXPANDED TRUE
2012-04-15 14:35:21: >> SEARCH GROUPS CUSTOM
2012-04-15 14:35:21: << GROUPS 
2012-04-15 14:35:41: >> SEARCH GROUPS
2012-04-15 14:35:41: << GROUPS 1172, 1171, 1170, 1169, 1168, 1167, 1166, 1165, 1164, 1163, 1162
2012-04-15 14:35:41: >> GET GROUP 1172 DISPLAYNAME
2012-04-15 14:35:41: << GROUP 1172 DISPLAYNAME 
2012-04-15 14:35:41: >> GET GROUP 1172 USERS
2012-04-15 14:36:11: Warning, sending 'GET GROUP 1172 USERS' failed (Skype command timeout).
2012-04-15 14:36:11: >> GET GROUP 1171 DISPLAYNAME
2012-04-15 14:36:11: << GROUP 1171 DISPLAYNAME 
2012-04-15 14:36:11: >> GET GROUP 1171 USERS
2012-04-15 14:36:41: Warning, sending 'GET GROUP 1171 USERS' failed (Skype command timeout).
2012-04-15 14:36:41: >> GET GROUP 1170 DISPLAYNAME
2012-04-15 14:36:42: << GROUP 1170 DISPLAYNAME 
2012-04-15 14:36:42: >> GET GROUP 1170 USERS
2012-04-15 14:37:12: Warning, sending 'GET GROUP 1170 USERS' failed (Skype command timeout).
2012-04-15 14:37:12: >> GET GROUP 1169 DISPLAYNAME
2012-04-15 14:37:12: << GROUP 1169 DISPLAYNAME 
2012-04-15 14:37:12: >> GET GROUP 1169 USERS
2012-04-15 14:37:42: Warning, sending 'GET GROUP 1169 USERS' failed (Skype command timeout).
2012-04-15 14:37:42: >> GET GROUP 1168 DISPLAYNAME
2012-04-15 14:37:42: << GROUP 1168 DISPLAYNAME 
2012-04-15 14:37:42: >> GET GROUP 1168 USERS
2012-04-15 14:38:12: Warning, sending 'GET GROUP 1168 USERS' failed (Skype command timeout).
2012-04-15 14:38:12: >> GET GROUP 1167 DISPLAYNAME
2012-04-15 14:38:12: << GROUP 1167 DISPLAYNAME 
2012-04-15 14:38:12: >> GET GROUP 1167 USERS
2012-04-15 14:38:42: Warning, sending 'GET GROUP 1167 USERS' failed (Skype command timeout).
2012-04-15 14:38:42: >> GET GROUP 1166 DISPLAYNAME
2012-04-15 14:38:42: << GROUP 1166 DISPLAYNAME 
2012-04-15 14:38:42: >> GET GROUP 1166 USERS
2012-04-15 14:39:12: Warning, sending 'GET GROUP 1166 USERS' failed (Skype command timeout).
2012-04-15 14:39:12: >> GET GROUP 1165 DISPLAYNAME
2012-04-15 14:39:12: << GROUP 1165 DISPLAYNAME 
2012-04-15 14:39:12: >> GET GROUP 1165 USERS
2012-04-15 14:39:42: Warning, sending 'GET GROUP 1165 USERS' failed (Skype command timeout).
2012-04-15 14:39:42: >> GET GROUP 1164 DISPLAYNAME
2012-04-15 14:39:42: << GROUP 1164 DISPLAYNAME 
2012-04-15 14:39:42: >> GET GROUP 1164 USERS
2012-04-15 14:40:12: Warning, sending 'GET GROUP 1164 USERS' failed (Skype command timeout).
2012-04-15 14:40:12: >> GET GROUP 1163 DISPLAYNAME
2012-04-15 14:40:12: << GROUP 1163 DISPLAYNAME 
2012-04-15 14:40:12: >> GET GROUP 1163 USERS
2012-04-15 14:40:42: Warning, sending 'GET GROUP 1163 USERS' failed (Skype command timeout).
2012-04-15 14:40:42: >> GET GROUP 1162 DISPLAYNAME
2012-04-15 14:40:42: << GROUP 1162 DISPLAYNAME 
2012-04-15 14:40:42: >> GET GROUP 1162 USERS
2012-04-15 14:41:12: Warning, sending 'GET GROUP 1162 USERS' failed (Skype command timeout).
2012-04-15 14:41:13: >> SEARCH GROUPS CUSTOM
2012-04-15 14:41:13: << GROUPS 
2012-04-15 14:41:13: >> ALTER CHAT #foo/$echo123;7f258ddbb5809f12 SETTOPIC uustopic
2012-04-15 14:41:13: << ALTER CHAT SETTOPIC
2012-04-15 14:41:14: >> SET USERSTATUS OFFLINE
2012-04-15 14:41:15: << CHAT #foo/$echo123;7f258ddbb5809f12 TOPIC newtopic
2012-04-15 14:41:15: << CHAT #foo/$echo123;7f258ddbb5809f12 ACTIVITY_TIMESTAMP 1334490073
2012-04-15 14:41:15: << CHAT #foo/$echo123;7f258ddbb5809f12 FRIENDLYNAME newtopic
2012-04-15 14:41:15: << CHATMESSAGE 1193 STATUS SENDING
2012-04-15 14:41:15: << USERSTATUS OFFLINE
2012-04-15 14:41:15: << USER foo ONLINESTATUS OFFLINE
2012-04-15 14:41:15: << USERSTATUS OFFLINE
2012-04-15 14:41:15: << USER echo123 ONLINESTATUS OFFLINE
2012-04-15 14:41:15: << GROUP 1168 NROFUSERS 1
2012-04-15 14:41:15: << CONNSTATUS OFFLINE

i typed change chat topic ~5 minutes before it got finally sent to skype...

i'm not sure is this problem of Skype4Py api, skype, bitlbee, bitlbee-skype or the x11 protocol Skype4Py uses...

when bitlbee disconnects from skyped, skyped tries to report status back to closed socket. this should be somehow improved not to send all those status offline changes if bitlbee is no longer listening

bitlbee was restarted and then it tries to report messages coming from skype to bitlbee. here's output from skyped -n -d:

2012-04-15 15:27:10: >> SET USERSTATUS OFFLINE
2012-04-15 15:27:10: << USERSTATUS OFFLINE
2012-04-15 15:27:10: Warning, receiving 1024 bytes failed ([Errno 104] Connection reset by peer).
2012-04-15 15:27:11: << USER glen666 ONLINESTATUS OFFLINE
2012-04-15 15:27:11: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=2
2012-04-15 15:27:13: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=3
2012-04-15 15:27:15: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=4
2012-04-15 15:27:17: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=5
2012-04-15 15:27:19: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=6
2012-04-15 15:27:21: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=7
2012-04-15 15:27:23: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=8
2012-04-15 15:27:25: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=9
2012-04-15 15:27:27: Warning, sending 'USER echo123 ONLINESTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=10
2012-04-15 15:27:29: << USERSTATUS OFFLINE
2012-04-15 15:27:29: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=2
2012-04-15 15:27:31: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=3
2012-04-15 15:27:33: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=4
2012-04-15 15:27:35: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=5
2012-04-15 15:27:37: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=6
2012-04-15 15:27:39: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=7
2012-04-15 15:27:41: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=8
2012-04-15 15:27:43: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=9
2012-04-15 15:27:45: Warning, sending 'USERSTATUS OFFLINE
' failed ([Errno 9] Bad file descriptor). count=10
....