Changeset ed1f5e8d for protocols/twitter/twitter_lib.c

Timestamp:

2016-11-27T13:01:33Z (8 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

87872c7

Parents:

f8c9347

Message:

Expand each (media) URL only once. Twitter likes duplication. #1275.

File:

• protocols/twitter/twitter_lib.c (modified) (2 diffs)

protocols/twitter/twitter_lib.c

@@ -710 +710 @@
                 return;
         if ((quoted = json_o_get(node, "quoted_status")) && quoted->type == json_object) {
-                /* New "retweets with comments" feature. Note that this info
-                 * seems to be included in the streaming API only! Grab the
+                /* New "retweets with comments" feature. Grab the
                  * full message and try to insert it when we run into the
                  * Tweet entity. */
@@ -751 +750 @@
                         char *pos, *new;
 
-                        if (!kort || !disp || !(pos = strstr(*text, kort))) {
+                        /* Skip if a required field is missing, if the t.co URL is not in fact 
+                           in the Tweet at all, or if the full-ish one *is* in it already
+                           (dupes appear, especially in streaming API). */
+                        if (!kort || !disp || !(pos = strstr(*text, kort)) || strstr(*text, disp)) {
                                 continue;
                         }