Changeset dbca297 for lib/proxy.c

Timestamp:

2015-12-09T07:46:21Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

977a9d5

Parents:

459dec8

Message:

proxy: fix validation of the proxytype value

Coverity says it could be an out of bounds read, but the value is set
internally, so not really. Still, good point about the condition being
wrong.

File:

• lib/proxy.c (modified) (1 diff)

lib/proxy.c

@@ -542 +542 @@
         phb->data = data;
 
-        if (proxyhost[0] && proxyport > 0 && proxytype >= 0 && proxytype <= G_N_ELEMENTS(proxy_connect_funcs_array)) {
+        if (proxyhost[0] && proxyport > 0 && proxytype >= 0 && proxytype < G_N_ELEMENTS(proxy_connect_funcs_array)) {
                 fun = proxy_connect_funcs_array[proxytype];
         } else {