Changeset bbff22d for protocols/twitter/twitter_http.c

Timestamp:

2015-10-09T02:41:01Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

b87e5dc

Parents:

c4e61db

git-author:

dequis <dx@…> (08-10-15 07:48:06)

git-committer:

dequis <dx@…> (09-10-15 02:41:01)

Message:

twitter: Fix some nitpicky issues reported by coverity

Mostly minor rare leaks that happen in error conditions, and one
dereference before null check in twitter_logout (the null check is
probably the wrong one there, but it doesn't hurt to keep it)

File:

• protocols/twitter/twitter_http.c (modified) (3 diffs)

protocols/twitter/twitter_http.c

@@ -53 +53 @@
         char *tmp;
         GString *request = g_string_new("");
-        void *ret;
+        void *ret = NULL;
         char *url_arguments;
         url_t *base_url = NULL;
@@ -72 +72 @@
                 base_url = g_new0(url_t, 1);
                 if (!url_set(base_url, url_string)) {
-                        g_free(base_url);
-                        return NULL;
+                        goto error;
                 }
         }
@@ -132 +131 @@
         }
 
+error:
         g_free(url_arguments);
         g_string_free(request, TRUE);