Changeset bad41f56

Timestamp:

2010-08-19T23:42:11Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

4d4a7ed

Parents:

acd7959

Message:

libpurple: Fix typing notifications (in and out). Closes #671.

Location:

protocols

Files:

• bee_user.c (modified) (1 diff)
• nogaim.h (modified) (1 diff)
• purple/purple.c (modified) (4 diffs)

protocols/bee_user.c

@@ -241 +241 @@
 }
 
-void imcb_buddy_typing( struct im_connection *ic, char *handle, uint32_t flags )
+void imcb_buddy_typing( struct im_connection *ic, const char *handle, uint32_t flags )
 {
         bee_user_t *bu;

protocols/nogaim.h

@@ -310 +310 @@
 G_MODULE_EXPORT void imcb_buddy_nick_hint( struct im_connection *ic, const char *handle, const char *nick );
 
-G_MODULE_EXPORT void imcb_buddy_typing( struct im_connection *ic, char *handle, uint32_t flags );
+G_MODULE_EXPORT void imcb_buddy_typing( struct im_connection *ic, const char *handle, uint32_t flags );
 G_MODULE_EXPORT struct bee_user *imcb_buddy_by_handle( struct im_connection *ic, const char *handle );
 G_MODULE_EXPORT void imcb_clean_handle( struct im_connection *ic, char *handle );

protocols/purple/purple.c

@@ -427 +427 @@
 {
         PurpleTypingState state = PURPLE_NOT_TYPING;
-        PurpleConversation *conv;
+        PurpleAccount *pa = ic->proto_data;
         
         if( flags & OPT_TYPING )
@@ -434 +434 @@
                 state = PURPLE_TYPED;
         
-        if( ( conv = purple_find_conversation_with_account( PURPLE_CONV_TYPE_IM,
-                                                            who, ic->proto_data ) ) == NULL )
-        {
-                purple_conv_im_set_typing_state( purple_conversation_get_im_data( conv ), state );
-                return 1;
-        }
-        else
-        {
-                return 0;
-        }
+        serv_send_typing( purple_account_get_connection( pa ), who, state );
+        
+        return 1;
 }
 
@@ -807 +800 @@
         
         imcb_buddy_msg( ic, (char*) who, (char*) message, 0, mtime );
+}
+
+/* No, this is not a ui_op but a signal. */
+static void prplcb_buddy_typing( PurpleAccount *account, const char *who, gpointer null )
+{
+        PurpleConversation *conv;
+        PurpleConvIm *im;
+        int state;
+        
+        if( ( conv = purple_find_conversation_with_account( PURPLE_CONV_TYPE_IM, who, account ) ) == NULL )
+                return;
+        
+        im = PURPLE_CONV_IM(conv);
+        switch( purple_conv_im_get_typing_state( im ) )
+        {
+        case PURPLE_TYPING:
+                state = OPT_TYPING;
+                break;
+        case PURPLE_TYPED:
+                state = OPT_THINKING;
+                break;
+        default:
+                state = 0;
+        }
+        
+        imcb_buddy_typing( purple_ic_by_pa( account ), who, state );
 }
 
@@ -1139 +1158 @@
         purple_prefs_load();
         
+        /* No, really. So far there were ui_ops for everything, but now suddenly
+           one needs to use signals for typing notification stuff. :-( */
+        purple_signal_connect( purple_conversations_get_handle(), "buddy-typing",
+                               &funcs, PURPLE_CALLBACK(prplcb_buddy_typing), NULL );
+        purple_signal_connect( purple_conversations_get_handle(), "buddy-typed",
+                               &funcs, PURPLE_CALLBACK(prplcb_buddy_typing), NULL );
+        purple_signal_connect( purple_conversations_get_handle(), "buddy-typing-stopped",
+                               &funcs, PURPLE_CALLBACK(prplcb_buddy_typing), NULL );
+        
         memset( &funcs, 0, sizeof( funcs ) );
         funcs.login = purple_login;