Changeset b75671d for protocols/msn/ns.c

Timestamp:

2015-06-17T22:47:26Z (9 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Children:

b441614

Parents:

d832164 (diff), 2f99f23 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge remote-tracking branch 'origin/master' into parson

File:

• protocols/msn/ns.c (modified) (10 diffs)

protocols/msn/ns.c

@@ -181 +181 @@
                 imcb_error(ic, "Error while reading from server");
                 imc_logout(ic, TRUE);
+                g_free(bytes);
                 return FALSE;
         }
@@ -188 +189 @@
         g_free(bytes);
 
-        /* Ignore ret == 0, it's already disconnected then. */
-        msn_handler(md);
-
-        return TRUE;
-        
+        return msn_handler(md);
 }
 
@@ -397 +394 @@
 
                                         if (inbox && folders) {
-                                                imcb_log(ic,
-                                                         "INBOX contains %s new messages, plus %s messages in other folders.", inbox,
-                                                         folders);
+                                                imcb_notify_email(ic,
+                                                        "INBOX contains %s new messages, plus %s messages in other folders.", inbox,
+                                                        folders);
                                         }
 
@@ -411 +408 @@
 
                                         if (from && fromname) {
-                                                imcb_log(ic, "Received an e-mail message from %s <%s>.", fromname,
-                                                         from);
+                                                imcb_notify_email(ic, "Received an e-mail message from %s <%s>.", fromname, from);
                                         }
 
@@ -420 +416 @@
                         } else if (g_strncasecmp(ct, "text/x-msmsgsactivemailnotification", 35) == 0) {
                                 /* Notification that a message has been read... Ignore it */
-                        } else {
-                                debug("Can't handle %s packet from notification server", ct);
                         }
 
@@ -626 +620 @@
         char l[4];
 
-        if ((bd->flags & 7) == 0 || (bd->flags & MSN_BUDDY_ADL_SYNCED)) {
+        if ((bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL)) == 0 || (bd->flags & MSN_BUDDY_ADL_SYNCED)) {
                 return FALSE;
         }
@@ -644 +638 @@
         }
 
-        g_snprintf(l, sizeof(l), "%d", bd->flags & 7);
+        g_snprintf(l, sizeof(l), "%d", bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL));
         c = xt_new_node("c", NULL, NULL);
         xt_add_attr(c, "n", handle);
@@ -697 +691 @@
                 struct msn_buddy_data *bd = bu->data;
 
-                if (bu->ic != ic || (bd->flags & 7) == 0) {
+                if (bu->ic != ic || (bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL)) == 0) {
                         continue;
                 }
@@ -727 +721 @@
 }
 
-// TODO: typing notifications, nudges lol, etc
-int msn_ns_sendmessage(struct im_connection *ic, bee_user_t *bu, const char *text)
+static int msn_ns_send_sdg(struct im_connection *ic, bee_user_t *bu, const char *message_type, const char *text)
 {
         struct msn_data *md = ic->proto_data;
@@ -734 +727 @@
         char *buf;
 
-        if (strncmp(text, "\r\r\r", 3) == 0) {
-                /* Err. Shouldn't happen but I guess it can. Don't send others
-                   any of the "SHAKE THAT THING" messages. :-D */
-                return 1;
-        }
-
-        buf = g_strdup_printf(MSN_MESSAGE_HEADERS, bu->handle, ic->acc->user, md->uuid, strlen(text), text);
+        buf = g_strdup_printf(MSN_MESSAGE_HEADERS, bu->handle, ic->acc->user, md->uuid, message_type, strlen(text), text);
         retval = msn_ns_write(ic, -1, "SDG %d %zd\r\n%s", ++md->trId, strlen(buf), buf);
         g_free(buf);
         return retval;
 }
+
+int msn_ns_send_typing(struct im_connection *ic, bee_user_t *bu)
+{
+        return msn_ns_send_sdg(ic, bu, "Control/Typing", "");
+}
+
+int msn_ns_send_message(struct im_connection *ic, bee_user_t *bu, const char *text)
+{
+        return msn_ns_send_sdg(ic, bu, "Text", text);
+}
+