Changeset af97b23 for protocols

Timestamp:

2008-02-16T13:17:52Z (17 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

ca60550

Parents:

2799ff9

Message:

Improved sasl_get_part() to deal with whitespace in challenge strings, as
described in RFC 2831 secion 7.1 (the #rule description). Closes bug #362.

File:

• protocols/jabber/sasl.c (modified) (3 diffs)

protocols/jabber/sasl.c

@@ -21 +21 @@
 *                                                                           *
 \***************************************************************************/
+
+#include <ctype.h>
 
 #include "jabber.h"
@@ -107 +109 @@
 }
 
-static char *sasl_get_part( char *data, char *field )
+/* Non-static function, but not mentioned in jabber.h because it's for internal
+   use, just that the unittest should be able to reach it... */
+char *sasl_get_part( char *data, char *field )
 {
         int i, len;
         
         len = strlen( field );
+        
+        while( isspace( *data ) || *data == ',' )
+                data ++;
         
         if( g_strncasecmp( data, field, len ) == 0 && data[len] == '=' )
@@ -129 +136 @@
                         }
                         
-                        /* If we got a comma, we got a new field. Check it. */
-                        if( data[i] == ',' &&
-                            g_strncasecmp( data + i + 1, field, len ) == 0 &&
-                            data[i+len+1] == '=' )
+                        /* If we got a comma, we got a new field. Check it,
+                           find the next key after it. */
+                        if( data[i] == ',' )
                         {
-                                i += len + 2;
-                                break;
+                                while( isspace( data[i] ) || data[i] == ',' )
+                                        i ++;
+                                
+                                if( g_strncasecmp( data + i, field, len ) == 0 &&
+                                    data[i+len] == '=' )
+                                {
+                                        i += len + 1;
+                                        break;
+                                }
                         }
                 }