Changeset af97b23

Timestamp:

2008-02-16T13:17:52Z (17 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

ca60550

Parents:

2799ff9

Message:

Improved sasl_get_part() to deal with whitespace in challenge strings, as
described in RFC 2831 secion 7.1 (the #rule description). Closes bug #362.

Files:

• protocols/jabber/sasl.c (modified) (3 diffs)
• tests/Makefile (modified) (1 diff)
• tests/check.c (modified) (2 diffs)
• tests/check_jabber_sasl.c (added)

protocols/jabber/sasl.c

@@ -21 +21 @@
 *                                                                           *
 \***************************************************************************/
+
+#include <ctype.h>
 
 #include "jabber.h"
@@ -107 +109 @@
 }
 
-static char *sasl_get_part( char *data, char *field )
+/* Non-static function, but not mentioned in jabber.h because it's for internal
+   use, just that the unittest should be able to reach it... */
+char *sasl_get_part( char *data, char *field )
 {
         int i, len;
         
         len = strlen( field );
+        
+        while( isspace( *data ) || *data == ',' )
+                data ++;
         
         if( g_strncasecmp( data, field, len ) == 0 && data[len] == '=' )
@@ -129 +136 @@
                         }
                         
-                        /* If we got a comma, we got a new field. Check it. */
-                        if( data[i] == ',' &&
-                            g_strncasecmp( data + i + 1, field, len ) == 0 &&
-                            data[i+len+1] == '=' )
+                        /* If we got a comma, we got a new field. Check it,
+                           find the next key after it. */
+                        if( data[i] == ',' )
                         {
-                                i += len + 2;
-                                break;
+                                while( isspace( data[i] ) || data[i] == ',' )
+                                        i ++;
+                                
+                                if( g_strncasecmp( data + i, field, len ) == 0 &&
+                                    data[i+len] == '=' )
+                                {
+                                        i += len + 1;
+                                        break;
+                                }
                         }
                 }

tests/Makefile

@@ -11 +11 @@
 distclean: clean
 
-main_objs = account.o bitlbee.o conf.o crypting.o help.o ipc.o irc.o irc_commands.o log.o nick.o query.o root_commands.o set.o storage.o storage_xml.o storage_text.o user.o 
+main_objs = account.o bitlbee.o conf.o crypting.o help.o ipc.o irc.o irc_commands.o log.o nick.o query.o root_commands.o set.o storage.o storage_xml.o storage_text.o user.o
 
-test_objs = check.o check_util.o check_nick.o check_md5.o check_arc.o check_irc.o check_help.o check_user.o check_crypting.o check_set.o
+test_objs = check.o check_util.o check_nick.o check_md5.o check_arc.o check_irc.o check_help.o check_user.o check_crypting.o check_set.o check_jabber_sasl.o
 
 check: $(test_objs) $(addprefix ../, $(main_objs)) ../protocols/protocols.o ../lib/lib.o

tests/check.c

@@ -66 +66 @@
 Suite *set_suite(void);
 
+/* From check_jabber_sasl.c */
+Suite *jabber_sasl_suite(void);
+
 int main (int argc, char **argv)
 {
@@ -111 +114 @@
         srunner_add_suite(sr, crypting_suite());
         srunner_add_suite(sr, set_suite());
+        srunner_add_suite(sr, jabber_sasl_suite());
         if (no_fork)
                 srunner_set_fork_status(sr, CK_NOFORK);