Changeset a880e34 for lib

Timestamp:

2015-02-28T20:40:07Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

a6b00fc

Parents:

8eb2e84

git-author:

dequis <dx@…> (28-02-15 19:40:16)

git-committer:

dequis <dx@…> (28-02-15 20:40:07)

Message:

Refactor oauth_params_del to fix use-after-free that i introduced

Yeah ok that was dumb.

This is essentially just using a 'data' variable instead of 'l->data',
but i went ahead and cleaned up the function.

File:

• lib/oauth.c (modified) (1 diff)

lib/oauth.c

@@ -96 +96 @@
 {
         int key_len = strlen(key);
-        GSList *l, *n;
-
-        if (params == NULL) {
+        GSList *l;
+
+        if (!params) {
                 return;
         }
 
-        for (l = *params; l; l = n) {
-                n = l->next;
-
-                if (strncmp((char *) l->data, key, key_len) == 0 &&
-                    ((char *) l->data)[key_len] == '=') {
-                        *params = g_slist_remove(*params, l->data);
-                        g_free(l->data);
+        for (l = *params; l; l = l->next) {
+                char *data = l->data;
+
+                if (strncmp(data, key, key_len) == 0 && data[key_len] == '=') {
+                        *params = g_slist_remove(*params, data);
+                        g_free(data);
                 }
         }