Changeset 05816dd for lib

Timestamp:

2015-02-22T22:44:40Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

570f183

Parents:

91f06e5

git-author:

dequis <dx@…> (22-02-15 22:04:08)

git-committer:

dequis <dx@…> (22-02-15 22:44:40)

Message:

coverity: Fix some (harmless?) use-after-free with g_slist_remove()

These were passing a pointer to a variable right after it was g_free()'d

They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.

File:

• lib/oauth.c (modified) (1 diff)

lib/oauth.c

@@ -107 +107 @@
                 if (strncmp((char *) l->data, key, key_len) == 0 &&
                     ((char *) l->data)[key_len] == '=') {
+                        *params = g_slist_remove(*params, l->data);
                         g_free(l->data);
-                        *params = g_slist_remove(*params, l->data);
                 }
         }