Changeset 67f6828 for protocols/twitter/twitter_lib.c

Timestamp:

2012-11-25T22:09:41Z (11 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

b235228

Parents:

f97b8e9

Message:

Only a few commands use twitter_message_id_from_command_arg(), others were
still using a decimal scanf format string. Messy code duplication. :-(

File:

• protocols/twitter/twitter_lib.c (modified) (4 diffs)

protocols/twitter/twitter_lib.c

@@ -67 +67 @@
         char *text;
         struct twitter_xml_user *user;
-        guint64 id, reply_to;
+        guint64 id, rt_id; /* Usually equal, with RTs id == *original* id */
+        guint64 reply_to;
 };
 
@@ -491 +492 @@
                         g_free(txs->text);
                         txs->text = g_strdup_printf("RT @%s: %s", rtxs->user->screen_name, rtxs->text);
+                        txs->rt_id = txs->id;
                         txs->id = rtxs->id;
                         txs_free(rtxs);
@@ -642 +644 @@
         td->log[td->log_id].bu = bee_user_by_handle(ic->bee, ic, txs->user->screen_name);
         
+        /* This is all getting hairy. :-( If we RT'ed something ourselves,
+           remember OUR id instead so undo will work. In other cases, the
+           original tweet's id should be remembered for deduplicating. */
+        if (txs->rt_id && strcmp(txs->user->screen_name, td->user) == 0)
+                td->log[td->log_id].id = txs->rt_id;
+        
         if (set_getbool(&ic->acc->set, "show_ids")) {
                 if (reply_to != -1)
@@ -1154 +1162 @@
                 return;
         
-        if ((id = json_o_get(parsed, "id")) && id->type == json_integer)
+        if ((id = json_o_get(parsed, "id")) && id->type == json_integer) {
                 td->last_status_id = id->u.integer;
+        }
         
         json_value_free(parsed);