Changeset 62f53b50 for protocols/msn/msn.c

Timestamp:

2010-10-02T05:34:53Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

2af3e23

Parents:

05bf2a0 (diff), 04cd284 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merging msnp13 branch which, confusingly, upgrades the msn module to use
MSNP15. (The reason for this is that A) IMHO MSNP13 is what causes most of
the pain in this upgade and B) I initially intended to only implement MSNP13
but then discovered MS doesn't support it anymore.)

This fixes issues with display names being forgotten, adding contacts (and
them automatically getting blocked sometimes!!), and adds support for
away/status messages and some support for sending offline messages.

File:

• protocols/msn/msn.c (modified) (19 diffs)

protocols/msn/msn.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2004 Wilmer van der Gaast and others                *
+  * Copyright 2002-2010 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -25 +25 @@
 
 #include "nogaim.h"
+#include "soap.h"
 #include "msn.h"
 
@@ -35 +36 @@
 static void msn_init( account_t *acc )
 {
-        set_add( &acc->set, "display_name", NULL, set_eval_display_name, acc );
-        set_add( &acc->set, "local_display_name", "false", set_eval_bool, acc );
+        set_t *s;
+        
+        s = set_add( &acc->set, "display_name", NULL, set_eval_display_name, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_ONLINE_ONLY;
+        
         set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
         set_add( &acc->set, "switchboard_keepalives", "false", set_eval_bool, acc );
+        
+        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -47 +53 @@
         
         ic->proto_data = md;
-        md->fd = -1;
         
         if( strchr( acc->user, '@' ) == NULL )
@@ -56 +61 @@
         }
         
-        imcb_log( ic, "Connecting" );
-        
-        md->fd = proxy_connect( "messenger.hotmail.com", 1863, msn_ns_connected, ic );
-        if( md->fd < 0 )
-        {
-                imcb_error( ic, "Could not connect to server" );
-                imc_logout( ic, TRUE );
-                return;
-        }
-        
         md->ic = ic;
         md->away_state = msn_away_state_list;
-        
-        msn_connections = g_slist_append( msn_connections, ic );
+        md->domaintree = g_tree_new( msn_domaintree_cmp );
+        md->ns->fd = -1;
+        
+        msn_connections = g_slist_prepend( msn_connections, ic );
+        
+        imcb_log( ic, "Connecting" );
+        msn_ns_connect( ic, md->ns, MSN_NS_HOST, MSN_NS_PORT );
 }
 
@@ -76 +76 @@
         struct msn_data *md = ic->proto_data;
         GSList *l;
+        int i;
         
         if( md )
@@ -85 +86 @@
                 */
                 
-                if( md->fd >= 0 )
-                        closesocket( md->fd );
-                
-                if( md->handler )
-                {
-                        if( md->handler->rxq ) g_free( md->handler->rxq );
-                        if( md->handler->cmd_text ) g_free( md->handler->cmd_text );
-                        g_free( md->handler );
-                }
+                msn_ns_close( md->ns );
                 
                 while( md->switchboards )
@@ -99 +92 @@
                 
                 msn_msgq_purge( ic, &md->msgq );
-                
-                while( md->groupcount > 0 )
-                        g_free( md->grouplist[--md->groupcount] );
-                g_free( md->grouplist );
+                msn_soapq_flush( ic, FALSE );
+                
+                for( i = 0; i < sizeof( md->tokens ) / sizeof( md->tokens[0] ); i ++ )
+                        g_free( md->tokens[i] );
+                g_free( md->lock_key );
+                g_free( md->pp_policy );
+                
+                while( md->groups )
+                {
+                        struct msn_group *mg = md->groups->data;
+                        g_free( mg->id );
+                        g_free( mg->name );
+                        g_free( mg );
+                        md->groups = g_slist_remove( md->groups, mg );
+                }
+                
+                g_tree_destroy( md->domaintree );
+                md->domaintree = NULL;
                 
                 while( md->grpq )
@@ -134 +141 @@
         if( strcmp( who, "raw" ) == 0 )
         {
-                msn_write( ic, message, strlen( message ) );
-                msn_write( ic, "\r\n", 2 );
+                msn_ns_write( ic, -1, "%s\r\n", message );
         }
         else
@@ -173 +179 @@
 static void msn_set_away( struct im_connection *ic, char *state, char *message )
 {
-        char buf[1024];
+        char *uux;
         struct msn_data *md = ic->proto_data;
         
@@ -181 +187 @@
                 md->away_state = msn_away_state_list + 1;
         
-        g_snprintf( buf, sizeof( buf ), "CHG %d %s\r\n", ++md->trId, md->away_state->code );
-        msn_write( ic, buf, strlen( buf ) );
-}
-
-static void msn_set_my_name( struct im_connection *ic, char *info )
-{
-        msn_set_display_name( ic, info );
+        if( !msn_ns_write( ic, -1, "CHG %d %s\r\n", ++md->trId, md->away_state->code ) )
+                return;
+        
+        uux = g_markup_printf_escaped( "<Data><PSM>%s</PSM><CurrentMedia></CurrentMedia>"
+                                       "</Data>", message ? message : "" );
+        msn_ns_write( ic, -1, "UUX %d %zd\r\n%s", ++md->trId, strlen( uux ), uux );
+        g_free( uux );
 }
 
@@ -200 +206 @@
         struct bee_user *bu = bee_user_by_handle( ic->bee, ic, who );
         
-        msn_buddy_list_add( ic, "FL", who, who, group );
+        msn_buddy_list_add( ic, MSN_BUDDY_FL, who, who, group );
         if( bu && bu->group )
-                msn_buddy_list_remove( ic, "FL", who, bu->group->name );
+                msn_buddy_list_remove( ic, MSN_BUDDY_FL, who, bu->group->name );
 }
 
 static void msn_remove_buddy( struct im_connection *ic, char *who, char *group )
 {
-        msn_buddy_list_remove( ic, "FL", who, NULL );
+        msn_buddy_list_remove( ic, MSN_BUDDY_FL, who, NULL );
 }
 
@@ -267 +273 @@
 static void msn_keepalive( struct im_connection *ic )
 {
-        msn_write( ic, "PNG\r\n", strlen( "PNG\r\n" ) );
+        msn_ns_write( ic, -1, "PNG\r\n" );
 }
 
 static void msn_add_permit( struct im_connection *ic, char *who )
 {
-        msn_buddy_list_add( ic, "AL", who, who, NULL );
+        msn_buddy_list_add( ic, MSN_BUDDY_AL, who, who, NULL );
 }
 
 static void msn_rem_permit( struct im_connection *ic, char *who )
 {
-        msn_buddy_list_remove( ic, "AL", who, NULL );
+        msn_buddy_list_remove( ic, MSN_BUDDY_AL, who, NULL );
 }
 
@@ -284 +290 @@
         struct msn_switchboard *sb;
         
-        msn_buddy_list_add( ic, "BL", who, who, NULL );
+        msn_buddy_list_add( ic, MSN_BUDDY_BL, who, who, NULL );
         
         /* If there's still a conversation with this person, close it. */
@@ -295 +301 @@
 static void msn_rem_deny( struct im_connection *ic, char *who )
 {
-        msn_buddy_list_remove( ic, "BL", who, NULL );
+        msn_buddy_list_remove( ic, MSN_BUDDY_BL, who, NULL );
 }
 
@@ -314 +320 @@
         account_t *acc = set->data;
         struct im_connection *ic = acc->ic;
-        
-        /* Allow any name if we're offline. */
-        if( ic == NULL )
-                return value;
+        struct msn_data *md = ic->proto_data;
         
         if( strlen( value ) > 129 )
@@ -325 +328 @@
         }
         
-        /* Returning NULL would be better, because the server still has to
-           confirm the name change. However, it looks a bit confusing to the
-           user. */
-        return msn_set_display_name( ic, value ) ? value : NULL;
+        if( md->flags & MSN_GOT_PROFILE_DN )
+                imcb_log( ic, "Warning: Persistent name changes for this account have to be done "
+                              "in the profile. BitlBee doesn't currently support this." );
+        
+        msn_soap_addressbook_set_display_name( ic, value );
+        return msn_ns_set_display_name( ic, value ) ? value : NULL;
+}
+
+static void msn_buddy_data_add( bee_user_t *bu )
+{
+        struct msn_data *md = bu->ic->proto_data;
+        bu->data = g_new0( struct msn_buddy_data, 1 );
+        g_tree_insert( md->domaintree, bu->handle, bu );
+}
+
+static void msn_buddy_data_free( bee_user_t *bu )
+{
+        struct msn_data *md = bu->ic->proto_data;
+        g_tree_remove( md->domaintree, bu->handle );
+        g_free( bu->data );
 }
 
@@ -343 +362 @@
         ret->set_away = msn_set_away;
         ret->get_info = msn_get_info;
-        ret->set_my_name = msn_set_my_name;
         ret->add_buddy = msn_add_buddy;
         ret->remove_buddy = msn_remove_buddy;
@@ -357 +375 @@
         ret->send_typing = msn_send_typing;
         ret->handle_cmp = g_strcasecmp;
+        ret->buddy_data_add = msn_buddy_data_add;
+        ret->buddy_data_free = msn_buddy_data_free;
+        
         //ret->transfer_request = msn_ftp_transfer_request;