Changeset 2abceca for protocols/twitter/twitter_lib.c

Timestamp:

2010-04-06T17:25:51Z (14 years ago)

Author:

Geert Mulders <g.c.w.m.mulders@…>

Branches:

master

Children:

0519b0a

Parents:

62d2cfb

Message:

Updates made as a result to the comments on the review.

File:

• protocols/twitter/twitter_lib.c (modified) (10 diffs)

protocols/twitter/twitter_lib.c

@@ -65 +65 @@
         g_free(txu->name);
         g_free(txu->screen_name);
+        g_free(txu);
 }
 
@@ -76 +77 @@
         g_free(txs->text);
         txu_free(txs->user);
+        g_free(txs);
 }
 
@@ -131 +133 @@
 {
         // Do something with the cursor.
-        txl->next_cursor = atoi(node->text);
+        txl->next_cursor = node->text != NULL ? atoi(node->text) : -1;
 
         return XT_HANDLED;
@@ -153 +155 @@
                 {
                         // Add the item to the list.
-                        txl->list = g_slist_append (txl->list, g_memdup( node->text, node->text_len + 1 ));
+                        txl->list = g_slist_append (txl->list, g_memdup( child->text, child->text_len + 1 ));
                 }
                 else if ( g_strcasecmp( "next_cursor", child->name ) == 0)
@@ -187 +189 @@
 
         txl = g_new0(struct twitter_xml_list, 1);
-        txl->list = NULL;
 
         // Parse the data.
@@ -451 +452 @@
         if (req->status_code != 200) {
                 // It didn't go well, output the error and return.
-                imcb_error(ic, "Could not retrieve home/timeline. HTTP STATUS: %d", req->status_code);
+                imcb_error(ic, "Could not retrieve " TWITTER_HOME_TIMELINE_URL ". HTTP STATUS: %d", req->status_code);
                 return;
         }
@@ -488 +489 @@
         struct xt_parser *parser;
         struct twitter_xml_list *txl;
+        GSList *l = NULL;
+        struct twitter_xml_user *user;
 
         // Check if the connection is still active.
@@ -496 +499 @@
         if (req->status_code != 200) {
                 // It didn't go well, output the error and return.
-                imcb_error(ic, "Could not retrieve home/timeline. HTTP STATUS: %d", req->status_code);
+                imcb_error(ic, "Could not retrieve " TWITTER_SHOW_FRIENDS_URL " HTTP STATUS: %d", req->status_code);
                 return;
         }
@@ -511 +514 @@
         xt_free( parser );
 
-        GSList *l = NULL;
-        struct twitter_xml_user *user;
         // Add the users as buddies.
         for ( l = txl->list; l ; l = g_slist_next(l) )
@@ -559 +560 @@
         if (req->status_code != 200) {
                 // It didn't go well, output the error and return.
-                imcb_error(ic, "Could not post tweed... HTTP STATUS: %d", req->status_code);
-                imcb_error(ic, req->reply_body);
+                imcb_error(ic, "Could not post tweet... HTTP STATUS: %d", req->status_code);
                 return;
         }