Changeset 1186382

Timestamp:

2007-10-10T22:15:59Z (17 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

285b55d

Parents:

8c2008e

Message:

Made the netsplit-like quit messages optional.

Files:

• doc/user-guide/commands.xml (modified) (1 diff)
• irc.c (modified) (2 diffs)
• protocols/nogaim.c (modified) (1 diff)

doc/user-guide/commands.xml

@@ -596 +596 @@
         </bitlbee-setting>
 
+        <bitlbee-setting name="simulate_netsplit" type="boolean" scope="global">
+                <default>true</default>
+
+                <description>
+                        <para>
+                                Some IRC clients parse quit messages sent by the IRC server to see if someone really left or just disappeared because of a netsplit. By default, BitlBee tries to simulate netsplit-like quit messages to keep the control channel window clean. If you don't like this (or if your IRC client doesn't support this) you can disable this setting.
+                        </para>
+                </description>
+        </bitlbee-setting>
+
         <bitlbee-setting name="ssl" type="boolean" scope="account">
                 <default>false</default>

irc.c

@@ -143 +143 @@
         set_add( &irc->set, "query_order", "lifo", NULL, irc );
         set_add( &irc->set, "save_on_quit", "true", set_eval_bool, irc );
+        set_add( &irc->set, "simulate_netsplit", "true", set_eval_bool, irc );
         set_add( &irc->set, "strip_html", "true", NULL, irc );
         set_add( &irc->set, "to_char", ": ", set_eval_to_char, irc );
@@ -910 +911 @@
         char reason[128];
         
-        if( u->ic && u->ic->flags & OPT_LOGGING_OUT )
+        if( u->ic && u->ic->flags & OPT_LOGGING_OUT && set_getbool( &irc->set, "simulate_netsplit" ) )
         {
                 if( u->ic->acc->server )

protocols/nogaim.c

@@ -586 +586 @@
               ( ( u->online == oo ) && ( oa == !u->away ) ) ) )         /* (De)voice people changing state */
         {
-                irc_write( ic->irc, ":%s MODE %s %cv %s", ic->irc->myhost,
-                                                          ic->irc->channel, u->away?'-':'+', u->nick );
+                char *from;
+                
+                if( set_getbool( &ic->irc->set, "simulate_netsplit" ) )
+                {
+                        from = g_strdup( ic->irc->myhost );
+                }
+                else
+                {
+                        from = g_strdup_printf( "%s!%s@%s", ic->irc->mynick, ic->irc->mynick,
+                                                            ic->irc->myhost );
+                }
+                irc_write( ic->irc, ":%s MODE %s %cv %s", from, ic->irc->channel,
+                                                          u->away?'-':'+', u->nick );
+                g_free( from );
         }
 }