Changeset 098a75b for lib

Timestamp:

2015-03-22T13:35:08Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

b95d03b

Parents:

2dd23da

git-author:

dequis <dx@…> (21-03-15 08:26:20)

git-committer:

dequis <dx@…> (22-03-15 13:35:08)

Message:

Fix a bunch of memory leaks

• irc_im.c:
  • bee_irc_user_msg: strdup leaks when otr swallows messages
  • bee_irc_user_action_response: GString leak in all ctcp replies
• otr.c:
  • call g_slist_free() on the list of the otr_policy setting
  • otr_filter_msg_in: call otrl_tlv_free() if "tlvs" are returned
  • otr_filter_msg_out: don't g_strdup() if the message should be ignored
  • log_otr_message: g_strdup_vprintf() leaks always
• nogaim.c:
  • imcb_ask_auth/imcb_ask_add: leaks in g_strdup_printf()
  • imcb_ask_add leaks imcb_ask_cb_data if the user already exists
  • add imcb_ask_cb_free() to correctly free its data
• msn_util.c: add msn_buddy_ask_free(), ditto
• storage_xml.c: pass_cr/password if base64_decode or arc_decode fail
• ssl_gnutls.c: conn->hostname leak in error conditions, like invalid certs
• jabber_util.c: jabber_buddy_by_ext_jid() leaks jid if it's not an ext jid

File:

• lib/ssl_gnutls.c (modified) (4 diffs)

lib/ssl_gnutls.c

@@ -124 +124 @@
 
         if (conn->fd < 0) {
+                g_free(conn->hostname);
                 g_free(conn);
                 return NULL;
@@ -314 +315 @@
         if (source == -1) {
                 conn->func(conn->data, 0, NULL, cond);
+                g_free(conn->hostname);
                 g_free(conn);
                 return FALSE;
@@ -355 +357 @@
                         conn->func(conn->data, 0, NULL, cond);
 
-                        gnutls_deinit(conn->session);
-                        closesocket(conn->fd);
-
-                        g_free(conn);
+                        ssl_disconnect(conn);
                 }
         } else {
@@ -364 +363 @@
                         conn->func(conn->data, stver, NULL, cond);
 
-                        gnutls_deinit(conn->session);
-                        closesocket(conn->fd);
-
-                        g_free(conn);
+                        ssl_disconnect(conn);
                 } else {
                         /* For now we can't handle non-blocking perfectly everywhere... */