Blank Line Spam

[incith@…]

During the entailings of some random luser who decided to message me, I discovered I could be bombarded with blank lines, of which an excerpt is below. Understandably a blank line is still a message in these cases, but I don't feel I need to be spammed like this. Perhaps a setting to limit the maximum number of blank lines in a row, or to strip/ignore blank lines.. of course users still use them to seperate paragraphs in messages, so stripping them completely wouldn't be the best solution I guess, but a limit to consecutive blank lines should be alright.

(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:
(20:59:49) < 320456010> incith:

[incith@…]

I just wanted to addenum that it seems my messaging him was causing him to disconnect, although I couldn't relay that to him. I don't see how BitlBee's ICQ sending code could be causing this, surely it must have been a fault in his client, but that would explain why he was getting madder and madder at me for no apparent reason. :-)

[timing]

Blank lines in the qlist are anoying too:

12:05:17 <@root> oscar - New request: The user 308058450 wants to add you to their buddy list for the following reason: 12:05:17 <@root> 12:05:17 <@root> add me to your Contact List 12:05:17 <@root> You can use the yes/no commands to accept/reject this request.

[timing]

drat:

12:05:17 <@root> oscar - New request: The user 308058450 wants to add you to their buddy list for the following reason:

12:05:17 <@root>

12:05:17 <@root> add me to your Contact List

12:05:17 <@root> You can use the yes/no commands to accept/reject this request.

[timing]

For the latter issue, removing one '\n' in protocols/oscar/oscar.c on line 1150 would be enough.

[wilmer]

I fixed timing's issue in [144]. Submitter, does this still bother you from time to time? Since this is probably a bug in your buddies, not in BitlBee. ;-)

But if this is really a problem, you can reopen this. I'll just close this because the OSCAR auth. request whitespace spam is fixed. BTS is getting a bit filled up.