Modify ↓
Opened at 2012-12-23T16:52:27Z
Closed at 2012-12-23T23:38:48Z
#1015 closed defect (fixed)
NOTICEs are ignored
| Reported by: | anonymous | Owned by: | wilmer |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | IRC | Version: | 3.0.6 |
| Keywords: | NOTICE ignored dropped | Cc: | |
| IRC client+version: | Client-independent | Operating System: | Linux |
| OS version/distro: | CentOS 6 |
Description
If the IRC client tries to /NOTICE an IM user, the /NOTICE is silently ignored/dropped. This should basically be converted to a PRIVMSG and sent to the IM client instead (since they probably don't differentiate between PM and NOTICE).
This is mainly noticeable when using bots, etc. that reply with NOTICE.
Attachments (0)
Change History (2)
comment:1 Changed at 2012-12-23T17:51:43Z by
comment:2 Changed at 2012-12-23T23:38:48Z by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Reasonable enough. changeset:devel,954.
Note: See
TracTickets for help on using
tickets.

Here is a modified irc_cmd_notice() to support the change:
static void irc_cmd_notice( irc_t *irc, char **cmd ) { irc_user_t *iu; if( !cmd[2] ) { irc_send_num( irc, 412, ":No text to send" ); return; } /* At least for now just echo. IIRC some IRC clients use self-notices for lag checks, so try to support that. */ if( nick_cmp( cmd[1], irc->user->nick ) == 0 ) { irc_send_msg( irc->user, "NOTICE", irc->user->nick, cmd[2], NULL ); } else if( ( iu = irc_user_by_name( irc, cmd[1] ) ) ) { iu->f->privmsg( iu, cmd[2] ); } }