Changes in protocols/twitter/twitter_lib.c [c43146d:fedc8f1]

File:

• protocols/twitter/twitter_lib.c (modified) (10 diffs)

protocols/twitter/twitter_lib.c

@@ -460 +460 @@
 #endif
 
-static void expand_entities(char **text, const json_value *node);
+static char* expand_entities(char* text, const json_value *entities);
 
 /**
@@ -473 +473 @@
 {
         struct twitter_xml_status *txs;
-        const json_value *rt = NULL;
+        const json_value *rt = NULL, *entities = NULL;
 
         if (node->type != json_object) {
@@ -501 +501 @@
                 } else if (strcmp("in_reply_to_status_id", k) == 0 && v->type == json_integer) {
                         txs->reply_to = v->u.integer;
+                } else if (strcmp("entities", k) == 0 && v->type == json_object) {
+                        entities = v;
                 }
         }
@@ -514 +516 @@
                         txs_free(rtxs);
                 }
-        } else {
-                expand_entities(&txs->text, node);
+        } else if (entities) {
+                txs->text = expand_entities(txs->text, entities);
         }
 
@@ -532 +534 @@
 {
         struct twitter_xml_status *txs;
+        const json_value *entities = NULL;
 
         if (node->type != json_object) {
@@ -558 +561 @@
         }
 
-        expand_entities(&txs->text, node);
+        if (entities) {
+                txs->text = expand_entities(txs->text, entities);
+        }
 
         if (txs->text && txs->user && txs->id) {
@@ -568 +573 @@
 }
 
-static void expand_entities(char **text, const json_value *node)
-{
-        json_value *entities, *quoted;
-        char *quote_url = NULL, *quote_text = NULL;
-
-        if (!((entities = json_o_get(node, "entities")) && entities->type == json_object))
-                return;
-        if ((quoted = json_o_get(node, "quoted_status")) && quoted->type == json_object) {
-                /* New "retweets with comments" feature. Note that this info
-                 * seems to be included in the streaming API only! Grab the
-                 * full message and try to insert it when we run into the
-                 * Tweet entity. */
-                struct twitter_xml_status *txs = twitter_xt_get_status(quoted);
-                quote_text = g_strdup_printf("@%s: %s", txs->user->screen_name, txs->text);
-                quote_url = g_strdup_printf("%s/status/%" G_GUINT64_FORMAT, txs->user->screen_name, txs->id);
-                txs_free(txs);
-        } else {
-                quoted = NULL;
-        }
-
+static char* expand_entities(char* text, const json_value *entities)
+{
         JSON_O_FOREACH(entities, k, v) {
                 int i;
@@ -599 +586 @@
 
                 for (i = 0; i < v->u.array.length; i++) {
-                        const char *format = "%s%s <%s>%s";
-
                         if (v->u.array.values[i]->type != json_object) {
                                 continue;
@@ -607 +592 @@
                         const char *kort = json_o_str(v->u.array.values[i], "url");
                         const char *disp = json_o_str(v->u.array.values[i], "display_url");
-                        const char *full = json_o_str(v->u.array.values[i], "expanded_url");
                         char *pos, *new;
 
-                        if (!kort || !disp || !(pos = strstr(*text, kort))) {
+                        if (!kort || !disp || !(pos = strstr(text, kort))) {
                                 continue;
                         }
-                        if (quote_url && strstr(full, quote_url)) {
-                                format = "%s<%s> [%s]%s";
-                                disp = quote_text;
-                        }
 
                         *pos = '\0';
-                        new = g_strdup_printf(format, *text, kort,
+                        new = g_strdup_printf("%s%s <%s>%s", text, kort,
                                               disp, pos + strlen(kort));
 
-                        g_free(*text);
-                        *text = new;
-                }
-        }
-        g_free(quote_text);
-        g_free(quote_url);
+                        g_free(text);
+                        text = new;
+                }
+        }
+
+        return text;
 }
 
@@ -701 +681 @@
         if (g_strcasecmp(txs->user->screen_name, td->user) == 0) {
                 td->log[td->log_id].id = txs->rt_id;
-                /* More useful than NULL. */
-                td->log[td->log_id].bu = &twitter_log_local_user;
         }