Changeset fb62f132 for protocols/twitter

Timestamp:

2016-03-23T20:23:36Z (9 years ago)

Author:

Flexo <nick@…>

Branches:

master

Children:

9cf63ac

Parents:

d701547

git-author:

Flexo <nick@…> (15-03-16 21:39:36)

git-committer:

Flexo <nick@…> (23-03-16 20:23:36)

Message:

Honour twitter's mutes and "hide retweets from this user" settings.

Location:

protocols/twitter

Files:

• twitter.c (modified) (1 diff)
• twitter.h (modified) (1 diff)
• twitter_lib.c (modified) (5 diffs)
• twitter_lib.h (modified) (2 diffs)

protocols/twitter/twitter.c

@@ -345 +345 @@
                 imcb_log(ic, "Getting contact list");
                 twitter_get_friends_ids(ic, -1);
+                twitter_get_mutes_ids(ic, -1);
+                twitter_get_noretweets_ids(ic, -1);
         } else {
                 twitter_main_loop_start(ic);

protocols/twitter/twitter.h

@@ -61 +61 @@
 
         GSList *follow_ids;
+        GSList *mutes_ids;
+        GSList *noretweets_ids;
         GSList *filters;
 

protocols/twitter/twitter_lib.c

@@ -240 +240 @@
 
 static void twitter_http_get_friends_ids(struct http_request *req);
+static void twitter_http_get_mutes_ids(struct http_request *req);
+static void twitter_http_get_noretweets_ids(struct http_request *req);
 
 /**
@@ -252 +254 @@
         args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
         twitter_http(ic, TWITTER_FRIENDS_IDS_URL, twitter_http_get_friends_ids, ic, 0, args, 2);
+
+        g_free(args[1]);
+}
+
+/**
+ * Get the muted users ids.
+ */
+void twitter_get_mutes_ids(struct im_connection *ic, gint64 next_cursor)
+{
+        char *args[2];
+
+        args[0] = "cursor";
+        args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
+        twitter_http(ic, TWITTER_MUTES_IDS_URL, twitter_http_get_mutes_ids, ic, 0, args, 2);
+
+        g_free(args[1]);
+}
+
+/**
+ * Get the ids for users from whom we should ignore retweets.
+ */
+void twitter_get_noretweets_ids(struct im_connection *ic, gint64 next_cursor)
+{
+        char *args[2];
+
+        args[0] = "cursor";
+        args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
+        twitter_http(ic, TWITTER_NORETWEETS_IDS_URL, twitter_http_get_noretweets_ids, ic, 0, args, 2);
 
         g_free(args[1]);
@@ -332 +362 @@
                 twitter_get_users_lookup(ic);
         }
+
+        txl->list = NULL;
+        txl_free(txl);
+}
+
+/**
+ * Callback for getting the mutes ids.
+ */
+static void twitter_http_get_mutes_ids(struct http_request *req)
+{
+        struct im_connection *ic = req->data;
+        json_value *parsed;
+        struct twitter_xml_list *txl;
+        struct twitter_data *td;
+
+        // Check if the connection is stil active
+        if (!g_slist_find(twitter_connections, ic)) {
+                return;
+        }
+
+        td = ic->proto_data;
+
+        // Parse the data.
+        if (!(parsed = twitter_parse_response(ic, req))) {
+                return;
+        }
+
+        txl = g_new0(struct twitter_xml_list, 1);
+        txl->list = td->mutes_ids;
+
+        /* mute ids API response is similar enough to friends response
+           to reuse this method */
+        twitter_xt_get_friends_id_list(parsed, txl);
+        json_value_free(parsed);
+
+        td->mutes_ids = txl->list;
+        if (txl->next_cursor) {
+                /* Recurse while there are still more pages */
+                twitter_get_mutes_ids(ic, txl->next_cursor);
+        }
+
+        txl->list = NULL;
+        txl_free(txl);
+}
+
+/**
+ * Callback for getting the no-retweets ids.
+ */
+static void twitter_http_get_noretweets_ids(struct http_request *req)
+{
+        struct im_connection *ic = req->data;
+        json_value *parsed;
+        struct twitter_xml_list *txl;
+        struct twitter_data *td;
+
+        // Check if the connection is stil active
+        if (!g_slist_find(twitter_connections, ic)) {
+                return;
+        }
+
+        td = ic->proto_data;
+
+        // Parse the data.
+        if (!(parsed = twitter_parse_response(ic, req))) {
+                return;
+        }
+
+        txl = g_new0(struct twitter_xml_list, 1);
+        txl->list = td->noretweets_ids;
+        
+        // Process the retweet ids
+        txl->type = TXL_ID;
+        if (parsed->type == json_array) {
+                unsigned int i;
+                for (i = 0; i < parsed->u.array.length; i++) {
+                        json_value *c = parsed->u.array.values[i];
+                        if (c->type != json_integer) {
+                                continue;
+                        }
+                        txl->list = g_slist_prepend(txl->list,
+                                                    g_strdup_printf("%"PRIu64, c->u.integer));
+                }
+        }
+
+        json_value_free(parsed);
+        td->noretweets_ids = txl->list;
 
         txl->list = NULL;
@@ -831 +947 @@
         struct twitter_data *td = ic->proto_data;
         char *last_id_str;
+        char *uid_str;
 
         if (status->user == NULL || status->text == NULL) {
+                return;
+        }
+        
+        /* Check this is not a tweet that should be muted */
+        uid_str = g_strdup_printf("%" PRIu64, status->user->uid);
+        if (g_slist_find_custom(td->mutes_ids, uid_str, (GCompareFunc)strcmp)) {
+                g_free(uid_str);
+                return;
+        }
+        if (status->id != status->rt_id && g_slist_find_custom(td->noretweets_ids, uid_str, (GCompareFunc)strcmp)) {
+                g_free(uid_str);
                 return;
         }
@@ -857 +985 @@
         set_setstr(&ic->acc->set, "_last_tweet", last_id_str);
         g_free(last_id_str);
+        g_free(uid_str);
 }
 

protocols/twitter/twitter_lib.h

@@ -63 +63 @@
 #define TWITTER_FRIENDS_IDS_URL "/friends/ids.json"
 #define TWITTER_FOLLOWERS_IDS_URL "/followers/ids.json"
+#define TWITTER_MUTES_IDS_URL "/mutes/users/ids.json"
+#define TWITTER_NORETWEETS_IDS_URL "/friendships/no_retweets/ids.json"
 
 /* Account URLs */
@@ -87 +89 @@
 gboolean twitter_get_timeline(struct im_connection *ic, gint64 next_cursor);
 void twitter_get_friends_ids(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_mutes_ids(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_noretweets_ids(struct im_connection *ic, gint64 next_cursor);
 void twitter_get_statuses_friends(struct im_connection *ic, gint64 next_cursor);