Changeset fb020ac for protocols/yahoo

Timestamp:

2010-03-07T18:43:23Z (15 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

279607e

Parents:

e08e53c (diff), c32f492 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merging in mainline, including improved away/status stuff.

Location:

protocols/yahoo

Files:

• libyahoo2.c (modified) (5 diffs)
• yahoo.c (modified) (5 diffs)

protocols/yahoo/libyahoo2.c

@@ -1530 +1530 @@
                         newbud = y_new0(struct yahoo_buddy, 1);
                         newbud->id = strdup(pair->value);
-                        if(cur_group)
+                        if (cur_group) {
                                 newbud->group = strdup(cur_group);
-                        else {
-                                struct yahoo_buddy *lastbud = (struct yahoo_buddy *)y_list_nth(
-                                                                yd->buddies, y_list_length(yd->buddies)-1)->data;
-                                newbud->group = strdup(lastbud->group);
+                        } else {
+                                YList *last;
+                                struct yahoo_buddy *lastbud;
+                                
+                                for (last = yd->buddies; last && last->next; last = last->next);
+                                if (last) {
+                                        lastbud = last->data;
+                                        newbud->group = strdup(lastbud->group);
+                                } else {
+                                        newbud->group = strdup("Buddies");
+                                }
                         }
 
@@ -2393 +2400 @@
 {
         struct yahoo_https_auth_data *had = req->data;
-        struct yahoo_input_data *yid = had->yid;
-        struct yahoo_data *yd = yid->yd;
+        struct yahoo_input_data *yid;
+        struct yahoo_data *yd;
         int st;
+        
+        if (y_list_find(inputs, had->yid) == NULL)
+                return;
+        
+        yid = had->yid;
+        yd = yid->yd;
         
         if (req->status_code != 200) {
@@ -2436 +2449 @@
 {
         struct yahoo_https_auth_data *had = req->data;
-        struct yahoo_input_data *yid = had->yid;
-        struct yahoo_data *yd = yid->yd;
+        struct yahoo_input_data *yid;
+        struct yahoo_data *yd;
         struct yahoo_packet *pack;
-        char *crumb;
+        char *crumb = NULL;
         int st;
+        
+        if (y_list_find(inputs, had->yid) == NULL)
+                return;
+        
+        yid = had->yid;
+        yd = yid->yd;
         
         md5_byte_t result[16];
@@ -4080 +4099 @@
 
         yd = yid->yd;
-
         old_status = yd->current_status;
-
-        if (msg && strncmp(msg,"Invisible",9)) {
-                yd->current_status = YAHOO_STATUS_CUSTOM;
-        } else {
-                yd->current_status = state;
-        }
+        yd->current_status = state;
 
         /* Thank you libpurple :) */
@@ -4102 +4115 @@
         snprintf(s, sizeof(s), "%d", yd->current_status);
         yahoo_packet_hash(pkt, 10, s);
-         
-        if (yd->current_status == YAHOO_STATUS_CUSTOM) {
-                yahoo_packet_hash(pkt, 19, msg);
-        } else {
-                yahoo_packet_hash(pkt, 19, "");
-        }
-        
+        yahoo_packet_hash(pkt, 19, msg && state == YAHOO_STATUS_CUSTOM ? msg : "");
         yahoo_packet_hash(pkt, 47, (away == 2)? "2": (away) ?"1":"0");
-
         yahoo_send_packet(yid, pkt, 0);
         yahoo_packet_free(pkt);

protocols/yahoo/yahoo.c

@@ -130 +130 @@
 {
         set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
+        
+        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -197 +199 @@
 {
         struct byahoo_data *yd = (struct byahoo_data *) ic->proto_data;
-        char *away;
-        
-        away = NULL;
-        
-        if( state && msg && g_strcasecmp( state, msg ) != 0 )
-        {
-                yd->current_status = YAHOO_STATUS_CUSTOM;
-                away = "";
-        }
-        else if( state )
-        {
-                /* Set msg to NULL since (if it isn't NULL already) it's equal
-                   to state. msg must be empty if we want to use an existing
-                   away state. */
-                msg = NULL;
-                
-                away = "";
-                if( g_strcasecmp( state, "Available" ) == 0 )
-                {
-                        yd->current_status = YAHOO_STATUS_AVAILABLE;
-                        away = NULL;
-                }
-                else if( g_strcasecmp( state, "Be Right Back" ) == 0 )
+        
+        if( state && msg == NULL )
+        {
+                /* Use these states only if msg doesn't contain additional
+                   info since away messages are only supported with CUSTOM. */
+                if( g_strcasecmp( state, "Be Right Back" ) == 0 )
                         yd->current_status = YAHOO_STATUS_BRB;
                 else if( g_strcasecmp( state, "Busy" ) == 0 )
@@ -239 +224 @@
                 else if( g_strcasecmp( state, "Invisible" ) == 0 )
                         yd->current_status = YAHOO_STATUS_INVISIBLE;
-                else if( g_strcasecmp( state, GAIM_AWAY_CUSTOM ) == 0 )
-                {
-                        yd->current_status = YAHOO_STATUS_AVAILABLE;
-                        
-                        away = NULL;
-                }
-        }
+                else
+                        yd->current_status = YAHOO_STATUS_CUSTOM;
+        }
+        else if( state )
+                yd->current_status = YAHOO_STATUS_CUSTOM;
         else
                 yd->current_status = YAHOO_STATUS_AVAILABLE;
         
-        yahoo_set_away( yd->y2_id, yd->current_status, msg, away != NULL ? 2 : 0 );
+        yahoo_set_away( yd->y2_id, yd->current_status, msg, state ? 2 : 0 );
 }
 
@@ -258 +241 @@
         if( m == NULL )
         {
-                m = g_list_append( m, "Available" );
                 m = g_list_append( m, "Be Right Back" );
                 m = g_list_append( m, "Busy" );
@@ -269 +251 @@
                 m = g_list_append( m, "Stepped Out" );
                 m = g_list_append( m, "Invisible" );
-                m = g_list_append( m, GAIM_AWAY_CUSTOM );
         }