Changes in / [3759849:eb6df6a]

Files:

• bitlbee.h (modified) (1 diff)
• doc/CHANGES (modified) (1 diff)
• doc/user-guide/commands.xml (modified) (3 diffs)
• protocols/jabber/iq.c (modified) (2 diffs)
• protocols/jabber/jabber.c (modified) (3 diffs)
• protocols/jabber/jabber.h (modified) (1 diff)
• protocols/jabber/jabber_util.c (modified) (1 diff)
• protocols/jabber/message.c (modified) (1 diff)
• protocols/twitter/twitter.c (modified) (7 diffs)
• protocols/twitter/twitter.h (modified) (3 diffs)
• protocols/twitter/twitter_lib.c (modified) (11 diffs)
• protocols/twitter/twitter_lib.h (modified) (1 diff)
• storage_xml.c (modified) (6 diffs)

bitlbee.h

@@ -38 +38 @@
 
 #define PACKAGE "BitlBee"
-#define BITLBEE_VERSION "1.2.7"
+#define BITLBEE_VERSION "1.2.8"
 #define VERSION BITLBEE_VERSION
 #define BITLBEE_VER(a,b,c) (((a) << 16) + ((b) << 8) + (c))
-#define BITLBEE_VERSION_CODE BITLBEE_VER(1, 2, 7)
+#define BITLBEE_VERSION_CODE BITLBEE_VER(1, 2, 8)
 
 #define MAX_STRING 511

doc/CHANGES

@@ -3 +3 @@
 
 http://bugs.bitlbee.org/bitlbee/timeline?daysback=90&changeset=on
+
+Version 1.2.8:
+- Now always using the AIM-style authentication method for OSCAR connections,
+  even when connecting to ICQ. This solves login issues some people were
+  having. (If you have problems, try changing the old_icq_auth setting.)
+- Twitter:
+  * Allow changing the Twitter API base URL so the module can also be used
+    for identi.ca or any other compatible network.
+  * Fetch the full list of Twitter contacts instead of slowly adding all
+    contacts as they post a message.
+  * Fixed message length counting.
+  * Allow following/unfollowing people using the usual add/remove commands.
+  * Better error reporting.
+- Added a user_agent setting to the Jabber module to get around artificial
+  client restrictions.
+- Allow nick changes (although only before register/identify).
+- Some more minor bugfixes/etc.
+
+Finished 4 Jul 2010
 
 Version 1.2.7:

doc/user-guide/commands.xml

@@ -633 +633 @@
         </bitlbee-setting>
 
+        <bitlbee-setting name="base_url" type="string" scope="account">
+                <default>http://twitter.com</default>
+
+                <description>
+                        <para>
+                                There are more services that understand the Twitter API than just Twitter.com. BitlBee can connect to all Twitter API implementations.
+                        </para>
+
+                        <para>
+                                For example, set this setting to <emphasis>http://identi.ca/api</emphasis> to use Identi.ca.
+                        </para>
+
+                        <para>
+                                Keep two things in mind: When not using Twitter, you <emphasis>must</emphasis> also disable the <emphasis>oauth</emphasis> setting as it currently only works with Twitter. If you're still having issues, make sure there is <emphasis>no</emphasis> slash at the end of the URL you enter here.
+                        </para>
+                </description>
+        </bitlbee-setting>
+
         <bitlbee-setting name="buddy_sendbuffer" type="boolean" scope="global">
                 <default>false</default>
@@ -1231 +1249 @@
         </bitlbee-setting>
 
+        <bitlbee-setting name="user_agent" type="string" scope="account">
+                <default>BitlBee</default>
+
+                <description>
+                        <para>
+                                Some Jabber servers are configured to only allow a few (or even just one) kinds of XMPP clients to connect to them.
+                        </para>
+                        
+                        <para>
+                                You can change this setting to make BitlBee present itself as a different client, so that you can still connect to these servers.
+                        </para>
+                </description>
+        </bitlbee-setting>
+
         <bitlbee-setting name="voice_buddies" type="string" scope="global">
                 <default>notaway</default>
@@ -1244 +1276 @@
                         </para>
                 </description>
-
         </bitlbee-setting>
 

protocols/jabber/iq.c

@@ -65 +65 @@
                 if( strcmp( s, XMLNS_VERSION ) == 0 )
                 {
-                        xt_add_child( reply, xt_new_node( "name", "BitlBee", NULL ) );
+                        xt_add_child( reply, xt_new_node( "name", set_getstr( &ic->acc->set, "user_agent" ), NULL ) );
                         xt_add_child( reply, xt_new_node( "version", BITLBEE_VERSION, NULL ) );
                         xt_add_child( reply, xt_new_node( "os", ARCH, NULL ) );
@@ -105 +105 @@
                         xt_add_attr( c, "category", "client" );
                         xt_add_attr( c, "type", "pc" );
-                        xt_add_attr( c, "name", "BitlBee" );
+                        xt_add_attr( c, "name", set_getstr( &ic->acc->set, "user_agent" ) );
                         xt_add_child( reply, c );
                         

protocols/jabber/jabber.c

@@ -79 +79 @@
         s = set_add( &acc->set, "tls", "try", set_eval_tls, acc );
         s->flags |= ACC_SET_OFFLINE_ONLY;
+        
+        s = set_add( &acc->set, "user_agent", "BitlBee", NULL, acc );
         
         s = set_add( &acc->set, "xmlconsole", "false", set_eval_bool, acc );
@@ -286 +288 @@
                 g_hash_table_destroy( jd->node_cache );
         
+        jabber_buddy_remove_all( ic );
+        
         xt_free( jd->xt );
         
@@ -470 +474 @@
 {
         /* Just any whitespace character is enough as a keepalive for XMPP sessions. */
-        jabber_write( ic, "\n", 1 );
+        if( !jabber_write( ic, "\n", 1 ) )
+                return;
         
         /* This runs the garbage collection every minute, which means every packet

protocols/jabber/jabber.h

@@ -230 +230 @@
 int jabber_buddy_remove( struct im_connection *ic, char *full_jid );
 int jabber_buddy_remove_bare( struct im_connection *ic, char *bare_jid );
+void jabber_buddy_remove_all( struct im_connection *ic );
 time_t jabber_get_timestamp( struct xt_node *xt );
 struct jabber_error *jabber_error_parse( struct xt_node *node, char *xmlns );

protocols/jabber/jabber_util.c

@@ -665 +665 @@
 }
 
+static gboolean jabber_buddy_remove_all_cb( gpointer key, gpointer value, gpointer data )
+{
+        struct jabber_buddy *bud, *next;
+        
+        bud = value;
+        while( bud )
+        {
+                next = bud->next;
+                g_free( bud->ext_jid );
+                g_free( bud->full_jid );
+                g_free( bud->away_message );
+                g_free( bud );
+                bud = next;
+        }
+        
+        return TRUE;
+}
+
+void jabber_buddy_remove_all( struct im_connection *ic )
+{
+        struct jabber_data *jd = ic->proto_data;
+        
+        g_hash_table_foreach_remove( jd->buddies, jabber_buddy_remove_all_cb, NULL );
+        g_hash_table_destroy( jd->buddies );
+}
+
 time_t jabber_get_timestamp( struct xt_node *xt )
 {

protocols/jabber/message.c

@@ -55 +55 @@
                         struct xt_node *inv, *reason;
                         
-                        if( strcmp( ns, XMLNS_MUC_USER ) == 0 &&
+                        if( ns && strcmp( ns, XMLNS_MUC_USER ) == 0 &&
                             ( inv = xt_find_node( c->children, "invite" ) ) )
                         {

protocols/twitter/twitter.c

@@ -40 +40 @@
                 return 0;
 
-        // If the user uses multiple private message windows we need to get the 
-        // users buddies.
-        if (g_strcasecmp(set_getstr(&ic->acc->set, "mode"), "many") == 0)
-                twitter_get_statuses_friends(ic, -1);
-
         // Do stuff..
         twitter_get_home_timeline(ic, -1);
@@ -56 +51 @@
         struct twitter_data *td = ic->proto_data;
         
-        imcb_log( ic, "Connecting to Twitter" );
+        imcb_log( ic, "Getting initial statuses" );
 
         // Run this once. After this queue the main loop function.
@@ -66 +61 @@
 }
 
+static void twitter_oauth_start( struct im_connection *ic );
+
+void twitter_login_finish( struct im_connection *ic )
+{
+        struct twitter_data *td = ic->proto_data;
+        
+        if( set_getbool( &ic->acc->set, "oauth" ) && !td->oauth_info )
+                twitter_oauth_start( ic );
+        else if( g_strcasecmp( set_getstr( &ic->acc->set, "mode" ), "one" ) != 0 &&
+                 !( td->flags & TWITTER_HAVE_FRIENDS ) )
+        {
+                imcb_log( ic, "Getting contact list" );
+                twitter_get_statuses_friends( ic, -1 );
+        }
+        else
+                twitter_main_loop_start( ic );
+}
 
 static const struct oauth_service twitter_oauth =
@@ -128 +140 @@
                 ic->acc->pass = oauth_to_string( info );
                 
-                twitter_main_loop_start( ic );
+                twitter_login_finish( ic );
         }
         
@@ -211 +223 @@
         imcb_buddy_status( ic, name, OPT_LOGGED_IN, NULL, NULL );
         
-        if( td->oauth_info || !set_getbool( &acc->set, "oauth" ) )
-                twitter_main_loop_start( ic );
-        else
-                twitter_oauth_start( ic );
+        imcb_log( ic, "Connecting" );
+        
+        twitter_login_finish( ic );
 }
 
@@ -236 +247 @@
         {
                 oauth_info_free( td->oauth_info );
+                g_free( td->url_host );
+                g_free( td->url_path );
                 g_free( td->pass );
                 g_free( td );
@@ -256 +269 @@
                     td->oauth_info && td->oauth_info->token == NULL )
                 {
-                        if( !oauth_access_token( message, td->oauth_info ) )
+                        char pin[strlen(message)+1], *s;
+                        
+                        strcpy( pin, message );
+                        for( s = pin + sizeof( pin ) - 2; s > pin && isspace( *s ); s -- )
+                                *s = '\0';
+                        for( s = pin; *s && isspace( *s ); s ++ ) {}
+                        
+                        if( !oauth_access_token( s, td->oauth_info ) )
                         {
                                 imcb_error( ic, "OAuth error: %s", "Failed to send access token request" );

protocols/twitter/twitter.h

@@ -33 +33 @@
 #endif
 
+typedef enum
+{
+        TWITTER_HAVE_FRIENDS = 1,
+} twitter_flags_t;
+
 struct twitter_data
 {
@@ -42 +47 @@
         struct groupchat *home_timeline_gc;
         gint http_fails;
+        twitter_flags_t flags;
         
         gboolean url_ssl;
@@ -56 +62 @@
 GSList *twitter_connections;
 
+void twitter_login_finish( struct im_connection *ic );
+
 #endif //_TWITTER_H

protocols/twitter/twitter_lib.c

@@ -42 +42 @@
 struct twitter_xml_list {
         int type;
-        int next_cursor;
+        gint64 next_cursor;
         GSList *list;
         gpointer data;
@@ -58 +58 @@
         guint64 id;
 };
+
+static void twitter_groupchat_init(struct im_connection *ic);
 
 /**
@@ -153 +155 @@
  * Get the friends ids.
  */
-void twitter_get_friends_ids(struct im_connection *ic, int next_cursor)
+void twitter_get_friends_ids(struct im_connection *ic, gint64 next_cursor)
 {
         // Primitive, but hey! It works...      
         char* args[2];
         args[0] = "cursor";
-        args[1] = g_strdup_printf ("%d", next_cursor);
+        args[1] = g_strdup_printf ("%lld", (long long) next_cursor);
         twitter_http(ic, TWITTER_FRIENDS_IDS_URL, twitter_http_get_friends_ids, ic, 0, args, 2);
 
@@ -169 +171 @@
 static xt_status twitter_xt_next_cursor( struct xt_node *node, struct twitter_xml_list *txl )
 {
-        // Do something with the cursor.
-        txl->next_cursor = node->text != NULL ? atoi(node->text) : -1;
+        char *end = NULL;
+        
+        if( node->text )
+                txl->next_cursor = g_ascii_strtoll( node->text, &end, 10 );
+        if( end == NULL )
+                txl->next_cursor = -1;
 
         return XT_HANDLED;
@@ -413 +419 @@
  * Get the timeline.
  */
-void twitter_get_home_timeline(struct im_connection *ic, int next_cursor)
+void twitter_get_home_timeline(struct im_connection *ic, gint64 next_cursor)
 {
         struct twitter_data *td = ic->proto_data;
@@ -419 +425 @@
         char* args[4];
         args[0] = "cursor";
-        args[1] = g_strdup_printf ("%d", next_cursor);
+        args[1] = g_strdup_printf ("%lld", (long long) next_cursor);
         if (td->home_timeline_id) {
                 args[2] = "since_id";
@@ -431 +437 @@
                 g_free(args[3]);
         }
+}
+
+static void twitter_groupchat_init(struct im_connection *ic)
+{
+        char *name_hint;
+        struct groupchat *gc;
+        struct twitter_data *td = ic->proto_data;
+        
+        td->home_timeline_gc = gc = imcb_chat_new( ic, "home/timeline" );
+        
+        name_hint = g_strdup_printf( "Twitter_%s", ic->acc->user );
+        imcb_chat_name_hint( gc, name_hint );
+        g_free( name_hint );
 }
 
@@ -445 +464 @@
         // Create a new groupchat if it does not exsist.
         if (!td->home_timeline_gc)
-        {   
-                char *name_hint = g_strdup_printf( "Twitter_%s", ic->acc->user );
-                td->home_timeline_gc = gc = imcb_chat_new( ic, "home/timeline" );
-                imcb_chat_name_hint( gc, name_hint );
-                g_free( name_hint );
-                // Add the current user to the chat...
+                twitter_groupchat_init(ic);
+        
+        gc = td->home_timeline_gc;
+        if (!gc->joined)
                 imcb_chat_add_buddy( gc, ic->acc->user );
-        }
-        else
-        {   
-                gc = td->home_timeline_gc;
-        }
 
         for ( l = list; l ; l = g_slist_next(l) )
@@ -604 +616 @@
         
         // Check if the HTTP request went well.
-        if (req->status_code != 200) {
+        if (req->status_code == 401)
+        {
+                imcb_error( ic, "Authentication failure" );
+                imc_logout( ic, FALSE );
+                return;
+        } else if (req->status_code != 200) {
                 // It didn't go well, output the error and return.
-                if (++td->http_fails >= 5)
-                        imcb_error(ic, "Could not retrieve " TWITTER_SHOW_FRIENDS_URL ": %s", twitter_parse_error(req));
-                
+                imcb_error(ic, "Could not retrieve " TWITTER_SHOW_FRIENDS_URL ": %s", twitter_parse_error(req));
+                imc_logout( ic, TRUE );
                 return;
         } else {
                 td->http_fails = 0;
         }
+        
+        if( !td->home_timeline_gc &&
+            g_strcasecmp( set_getstr( &ic->acc->set, "mode" ), "chat" ) == 0 )
+                twitter_groupchat_init( ic );
 
         txl = g_new0(struct twitter_xml_list, 1);
@@ -634 +654 @@
         // if the next_cursor is set to something bigger then 0 there are more friends to gather.
         if (txl->next_cursor > 0)
+        {
                 twitter_get_statuses_friends(ic, txl->next_cursor);
-
+        }
+        else
+        {
+                td->flags |= TWITTER_HAVE_FRIENDS;
+                twitter_login_finish(ic);
+        }
+        
         // Free the structure.
         txl_free(txl);
@@ -644 +671 @@
  * Get the friends.
  */
-void twitter_get_statuses_friends(struct im_connection *ic, int next_cursor)
+void twitter_get_statuses_friends(struct im_connection *ic, gint64 next_cursor)
 {
         char* args[2];
         args[0] = "cursor";
-        args[1] = g_strdup_printf ("%d", next_cursor);
+        args[1] = g_strdup_printf ("%lld", (long long) next_cursor);
 
         twitter_http(ic, TWITTER_SHOW_FRIENDS_URL, twitter_http_get_statuses_friends, ic, 0, args, 2);

protocols/twitter/twitter_lib.h

@@ -76 +76 @@
 #define TWITTER_BLOCKS_DESTROY_URL "/blocks/destroy/"
 
-void twitter_get_friends_ids(struct im_connection *ic, int next_cursor);
-void twitter_get_home_timeline(struct im_connection *ic, int next_cursor);
-void twitter_get_statuses_friends(struct im_connection *ic, int next_cursor);
+void twitter_get_friends_ids(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_home_timeline(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_statuses_friends(struct im_connection *ic, gint64 next_cursor);
 
 void twitter_post_status(struct im_connection *ic, char *msg);

storage_xml.c

@@ -60 +60 @@
         char *given_pass;
         xml_pass_st pass_st;
+        int unknown_tag;
 };
 
@@ -87 +88 @@
         irc_t *irc = xd->irc;
         
-        if( g_strcasecmp( element_name, "user" ) == 0 )
+        if( xd->unknown_tag > 0 )
+        {
+                xd->unknown_tag ++;
+        }
+        else if( g_strcasecmp( element_name, "user" ) == 0 )
         {
                 char *nick = xml_attr( attr_names, attr_values, "nick" );
@@ -225 +230 @@
         else
         {
+                xd->unknown_tag ++;
+                irc_usermsg( irc, "Warning: Unknown XML tag found in configuration file (%s). "
+                                  "This may happen when downgrading BitlBee versions. "
+                                  "This tag will be skipped and the information will be lost "
+                                  "once you save your settings.", element_name );
+                /*
                 g_set_error( error, G_MARKUP_ERROR, G_MARKUP_ERROR_UNKNOWN_ELEMENT,
                              "Unkown element: %s", element_name );
+                */
         }
 }
@@ -234 +246 @@
         struct xml_parsedata *xd = data;
         
-        if( g_strcasecmp( element_name, "setting" ) == 0 && xd->current_setting )
+        if( xd->unknown_tag > 0 )
+        {
+                xd->unknown_tag --;
+        }
+        else if( g_strcasecmp( element_name, "setting" ) == 0 && xd->current_setting )
         {
                 g_free( xd->current_setting );
@@ -404 +420 @@
                 return STORAGE_ALREADY_EXISTS;
         
-        strcat( path, "~" );
-        if( ( fd = open( path, O_WRONLY | O_CREAT | O_TRUNC, 0600 ) ) < 0 )
+        strcat( path, ".XXXXXX" );
+        if( ( fd = mkstemp( path ) ) < 0 )
         {
                 irc_usermsg( irc, "Error while opening configuration file." );
@@ -499 +515 @@
         close( fd );
         
-        path2 = g_strndup( path, strlen( path ) - 1 );
+        path2 = g_strndup( path, strlen( path ) - 7 );
         if( rename( path, path2 ) != 0 )
         {