Changeset ea39049

Timestamp:

2015-12-17T16:56:25Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

f66425d

Parents:

d11ccbf

Message:

ini: Null check file parameter before passing it to open()

The test suite does this. It's harmless in practice but open() is
declared as nonnull. Thanks to clang's ubsan.

File:

• lib/ini.c (modified) (1 diff)

lib/ini.c

@@ -28 +28 @@
 ini_t *ini_open(char *file)
 {
-        int fd;
+        int fd = -1;
         ini_t *ini = NULL;
         struct stat fi;
 
-        if ((fd = open(file, O_RDONLY)) != -1 &&
+        if (file && (fd = open(file, O_RDONLY)) != -1 &&
             fstat(fd, &fi) == 0 &&
             fi.st_size <= 16384 &&