Changes in / [3ef6410:e97827b]

Files:

• protocols/msn/msn.c (modified) (2 diffs)
• protocols/msn/msn.h (modified) (1 diff)
• protocols/msn/msn_util.c (modified) (4 diffs)
• protocols/msn/passport.c (modified) (3 diffs)
• protocols/yahoo/yahoo.c (modified) (2 diffs)
• root_commands.c (modified) (1 diff)

protocols/msn/msn.c

@@ -366 +366 @@
         struct gaim_connection *gc = acc->gc;
         struct msn_data *md;
-        char buf[1024], *fn, *s;
+        char buf[1024], *fn;
         int i;
         
@@ -381 +381 @@
         }
         
-        /* Of course we could use http_encode() here, but when we encode
-           every character, the server is less likely to complain about the
-           chosen name. However, the MSN server doesn't seem to like escaped
-           non-ASCII chars, so we keep those unescaped. */
-        s = fn = g_new0( char, strlen( value ) * 3 + 1 );
-        for( i = 0; value[i]; i ++ )
-                if( value[i] & 128 )
-                {
-                        *s = value[i];
-                        s ++;
-                }
-                else
-                {
-                        g_snprintf( s, 4, "%%%02X", value[i] );
-                        s += 3;
-                }
+        fn = msn_http_encode( value );
         
         g_snprintf( buf, sizeof( buf ), "REA %d %s %s\r\n", ++md->trId, gc->username, fn );

protocols/msn/msn.h

@@ -157 +157 @@
 char **msn_linesplit( char *line );
 int msn_handler( struct msn_handler_data *h );
+char *msn_http_encode( const char *input );
 
 /* tables.c */

protocols/msn/msn_util.c

@@ -54 +54 @@
 {
         struct msn_data *md = gc->proto_data;
-        GSList *l, **lp = NULL;
         char buf[1024], *realname;
         
-        if( strcmp( list, "AL" ) == 0 )
-                lp = &gc->permit;
-        else if( strcmp( list, "BL" ) == 0 )
-                lp = &gc->deny;
-        
-        if( lp )
-                for( l = *lp; l; l = l->next )
-                        if( g_strcasecmp( l->data, who ) == 0 )
-                                return( 1 );
-        
-        realname = g_new0( char, strlen( realname_ ) * 3 + 1 );
-        strcpy( realname, realname_ );
-        http_encode( realname );
+        realname = msn_http_encode( realname_ );
         
         g_snprintf( buf, sizeof( buf ), "ADD %d %s %s %s\r\n", ++md->trId, list, who, realname );
@@ -76 +63 @@
                 g_free( realname );
                 
-                if( lp )
-                        *lp = g_slist_append( *lp, g_strdup( who ) );
-                
                 return( 1 );
         }
@@ -90 +74 @@
 {
         struct msn_data *md = gc->proto_data;
-        GSList *l = NULL, **lp = NULL;
         char buf[1024];
-        
-        if( strcmp( list, "AL" ) == 0 )
-                lp = &gc->permit;
-        else if( strcmp( list, "BL" ) == 0 )
-                lp = &gc->deny;
-        
-        if( lp )
-        {
-                for( l = *lp; l; l = l->next )
-                        if( g_strcasecmp( l->data, who ) == 0 )
-                                break;
-                
-                if( !l )
-                        return( 1 );
-        }
         
         g_snprintf( buf, sizeof( buf ), "REM %d %s %s\r\n", ++md->trId, list, who );
         if( msn_write( gc, buf, strlen( buf ) ) )
-        {
-                if( lp )
-                        *lp = g_slist_remove( *lp, l->data );
-                
                 return( 1 );
-        }
         
         return( 0 );
@@ -350 +313 @@
         return( 1 );
 }
+
+/* The difference between this function and the normal http_encode() function
+   is that this one escapes every 7-bit ASCII character because this is said
+   to avoid some lame server-side checks when setting a real-name. Also,
+   non-ASCII characters are not escaped because MSN servers don't seem to
+   appreciate that! */
+char *msn_http_encode( const char *input )
+{
+        char *ret, *s;
+        int i;
+        
+        ret = s = g_new0( char, strlen( input ) * 3 + 1 );
+        for( i = 0; input[i]; i ++ )
+                if( input[i] & 128 )
+                {
+                        *s = input[i];
+                        s ++;
+                }
+                else
+                {
+                        g_snprintf( s, 4, "%%%02X", input[i] );
+                        s += 3;
+                }
+        
+        return ret;
+}

protocols/msn/passport.c

@@ -59 +59 @@
         rep->data = data;
         rep->func = func;
+        rep->header = header;
         
         server = g_strdup( prd_cached );
@@ -125 +126 @@
 static char *passport_create_header( char *cookie, char *email, char *pwd )
 {
-        char *buffer = g_new0( char, 2048 );
+        char *buffer;
         char *currenttoken;
         char *email_enc, *pwd_enc;
+        
+        currenttoken = strstr( cookie, "lc=" );
+        if( currenttoken == NULL )
+                return NULL;
         
         email_enc = g_new0( char, strlen( email ) * 3 + 1 );
@@ -137 +142 @@
         http_encode( pwd_enc );
         
-        currenttoken = strstr( cookie, "lc=" );
-        if( currenttoken == NULL )
-                return( NULL );
-        
-        g_snprintf( buffer, 2048,
-                    "Authorization: Passport1.4 OrgVerb=GET,"
-                    "OrgURL=http%%3A%%2F%%2Fmessenger%%2Emsn%%2Ecom,"
-                    "sign-in=%s,pwd=%s,%s", email_enc, pwd_enc,
-                    currenttoken );
+        buffer = g_strdup_printf( "Authorization: Passport1.4 OrgVerb=GET,"
+                                  "OrgURL=http%%3A%%2F%%2Fmessenger%%2Emsn%%2Ecom,"
+                                  "sign-in=%s,pwd=%s,%s", email_enc, pwd_enc,
+                                  currenttoken );
         
         g_free( email_enc );
         g_free( pwd_enc );
         
-        return( buffer );
+        return buffer;
 }
 

protocols/yahoo/yahoo.c

@@ -192 +192 @@
         gc->away = NULL;
         
-        if( msg )
+        if( state && msg && g_strcasecmp( state, msg ) != 0 )
         {
                 yd->current_status = YAHOO_STATUS_CUSTOM;
                 gc->away = "";
         }
-        if( state )
-        {
+        else if( state )
+        {
+                /* Set msg to NULL since (if it isn't NULL already) it's equal
+                   to state. msg must be empty if we want to use an existing
+                   away state. */
+                msg = NULL;
+                
                 gc->away = "";
                 if( g_strcasecmp( state, "Available" ) == 0 )
@@ -235 +240 @@
                 yd->current_status = YAHOO_STATUS_AVAILABLE;
         
-        if( yd->current_status == YAHOO_STATUS_INVISIBLE )
-                yahoo_set_away( yd->y2_id, yd->current_status, NULL, gc->away != NULL );
-        else
-                yahoo_set_away( yd->y2_id, yd->current_status, msg, gc->away != NULL );
+        yahoo_set_away( yd->y2_id, yd->current_status, msg, gc->away != NULL );
 }
 

root_commands.c

@@ -656 +656 @@
                 
                 irc_usermsg( irc, format, "Handle", "Nickname" );
-                for( l = a->gc->deny; l; l = l->next )
+                for( l = a->gc->permit; l; l = l->next )
                 {
                         user_t *u = user_findhandle( a->gc, l->data );