Changeset e1bea35

Timestamp:

2015-10-08T09:38:15Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

c4e61db

Parents:

c788e15

Message:

Fix use-after-free when leaving invited (temporary) channels

Trac ticket 1229, ​https://bugs.bitlbee.org/bitlbee/ticket/1229

This one is complicated. See the trac ticket for details.

Relevant commits: cc20520 6963230 664bac3 - second one fixed the same
issue, third one reverted it, this one takes a different approach.

File:

• irc_im.c (modified) (1 diff)

irc_im.c

@@ -863 +863 @@
         }
 
-        /* Remove the reference. We don't need it anymore. */
-        ic->data = NULL;
+        if (!(ic->flags & IRC_CHANNEL_TEMP)) {
+                /* Remove the reference.
+                 * We only need it for temp channels that are being freed */
+                ic->data = NULL;
+        }
 
         return TRUE;