Changeset de26f3c

Timestamp:

2011-10-30T11:33:49Z (13 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

ff1616b

Parents:

e6b41b1

Message:

Killed careless use of strcpy(). Luckily these are only a risk on public
servers.

File:

• protocols/jabber/s5bytestream.c (modified) (3 diffs)

protocols/jabber/s5bytestream.c

@@ -877 +877 @@
 
         if( ( ( host = strchr( proxy, ',' ) ) == 0 ) ||
-             ( ( port = strchr( host+1, ',' ) ) == 0 ) ) {
+            ( ( port = strchr( host+1, ',' ) ) == 0 ) )
+        {
                 imcb_log( ic, "Error parsing proxy setting: \"%s\" (ignored)", proxy );
                 return NULL;
@@ -889 +890 @@
         sh->jid = g_strdup( jid );
         sh->host = g_strdup( host );
-        strcpy( sh->port, port );
+        g_snprintf( sh->port, sizeof( sh->port ), "%s", port );
 
         return sh;
@@ -915 +916 @@
                                 sh->jid = g_strdup( tf->ini_jid );
                                 sh->host = g_strdup( host );
-                                strcpy( sh->port, port );
+                                g_snprintf( sh->port, sizeof( sh->port ), "%s", port );
                                 bt->streamhosts = g_slist_append( bt->streamhosts, sh );