Changeset d2d2b80

Timestamp:

2015-05-28T05:52:44Z (10 years ago)

Author:

dequis <dx@…>

Children:

51b14b8

Parents:

a1d30c5 (diff), b38f655 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'develop' into feat/hip-cat

Files:

• doc/user-guide/commands.xml (modified) (1 diff)
• protocols/bee.h (modified) (1 diff)
• protocols/bee_user.c (modified) (1 diff)
• protocols/jabber/iq.c (modified) (7 diffs)
• protocols/jabber/jabber.c (modified) (3 diffs)
• protocols/jabber/jabber.h (modified) (3 diffs)
• protocols/msn/msn.c (modified) (2 diffs)
• protocols/msn/ns.c (modified) (2 diffs)
• protocols/purple/purple.c (modified) (3 diffs)
• protocols/yahoo/yahoo.c (modified) (3 diffs)

doc/user-guide/commands.xml

@@ -1017 +1017 @@
                 <description>
                         <para>
-                                Some protocols (MSN, Yahoo!) can notify via IM about new e-mail. Since most people use their Hotmail/Yahoo! addresses as a spam-box, this is disabled default. If you want these notifications, you can enable this setting.
+                                Some protocols (MSN, Yahoo!, GTalk) can notify via IM about new e-mail. Since most people use their Hotmail/Yahoo! addresses as a spam-box, this is disabled default. If you want these notifications, you can enable this setting.
+                        </para>
+                </description>
+
+        </bitlbee-setting>
+
+        <bitlbee-setting name="mail_notifications_handle" type="string" scope="account">
+                <default>empty</default>
+
+                <description>
+                        <para>
+                                This setting is available for protocols with e-mail notification functionality. If set to empty all e-mail notifications will go to control channel, if set to some string - this will be the name of a contact who will PRIVMSG you on every new notification.
                         </para>
                 </description>

protocols/bee.h

@@ -158 +158 @@
 G_MODULE_EXPORT void imcb_buddy_msg(struct im_connection *ic, const char *handle, const char *msg, guint32 flags,
                                     time_t sent_at);
+G_MODULE_EXPORT void imcb_notify_email(struct im_connection *ic, char *format, ...) G_GNUC_PRINTF(2, 3);
 
 /* bee_chat.c */

protocols/bee_user.c

@@ -271 +271 @@
 }
 
+void imcb_notify_email(struct im_connection *ic, char *format, ...)
+{
+        const char *handle;
+        va_list params;
+        char *msg;
+
+        if (!set_getbool(&ic->acc->set, "mail_notifications")) {
+                return;
+        }
+
+        va_start(params, format);
+        msg = g_strdup_vprintf(format, params);
+        va_end(params);
+
+        /* up to the protocol to set_add this if they want to use this */
+        handle = set_getstr(&ic->acc->set, "mail_notifications_handle");
+
+        if (handle != NULL) {
+                imcb_buddy_msg(ic, handle, msg, 0, 0);
+        } else {
+                imcb_log(ic, "%s", msg);
+        }
+
+        g_free(msg);
+}
+
 void imcb_buddy_typing(struct im_connection *ic, const char *handle, uint32_t flags)
 {

protocols/jabber/iq.c

@@ -27 +27 @@
 static xt_status jabber_parse_roster(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
 static xt_status jabber_iq_display_vcard(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
+static xt_status jabber_gmail_handle_new(struct im_connection *ic, struct xt_node *node);
 
 xt_status jabber_pkt_iq(struct xt_node *node, gpointer data)
@@ -141 +142 @@
                     (strcmp(s, XMLNS_SI) == 0)) {
                         return jabber_si_handle_request(ic, node, c);
+                } else if ((c = xt_find_node(node->children, "new-mail")) &&
+                           (s = xt_find_attr(c, "xmlns")) &&
+                           (strcmp(s, XMLNS_GMAILNOTIFY) == 0)) {
+                        return jabber_gmail_handle_new(ic, node);
                 } else if (!(c = xt_find_node(node->children, "query")) ||
                            !(s = xt_find_attr(c, "xmlns"))) {
@@ -342 +347 @@
                         return XT_ABORT;
                 }
+                if (jd->flags & JFLAG_GMAILNOTIFY && node == NULL) {
+                        jabber_iq_query_server(ic, jd->server, XMLNS_DISCO_INFO);
+                }
         } else if ((jd->flags & (JFLAG_WANT_BIND | JFLAG_WANT_SESSION)) == 0) {
                 if (!jabber_get_roster(ic)) {
@@ -369 +377 @@
 
         return st;
+}
+
+xt_status jabber_iq_query_gmail(struct im_connection *ic);
+
+static xt_status jabber_gmail_handle_new(struct im_connection *ic, struct xt_node *node)
+{
+        struct xt_node *response;
+        struct jabber_data *jd = ic->proto_data;
+
+        response = jabber_make_packet("iq", "result", g_strdup_printf("%s@%s", jd->username, jd->server), NULL);
+
+        jabber_cache_add(ic, response, NULL);
+        if (!jabber_write_packet(ic, response)) {
+                return XT_ABORT;
+        }
+
+        jabber_iq_query_gmail(ic);
+
+        return XT_HANDLED;
 }
 
@@ -710 +737 @@
 }
 
+xt_status jabber_iq_parse_gmail(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
+
+xt_status jabber_iq_query_gmail(struct im_connection *ic)
+{
+        struct xt_node *node, *query;
+        struct jabber_data *jd = ic->proto_data;
+
+        node = xt_new_node("query", NULL, NULL);
+        xt_add_attr(node, "xmlns", XMLNS_GMAILNOTIFY);
+        if (jd->gmail_time) {
+                char *formatted = g_strdup_printf("%" G_GUINT64_FORMAT, (jd->gmail_time + 1));
+                xt_add_attr(node, "newer-than-time", formatted);
+                g_free(formatted);
+        }
+        if (jd->gmail_tid) {
+                xt_add_attr(node, "newer-than-tid", jd->gmail_tid);
+        }
+
+        if (!(query = jabber_make_packet("iq", "get", jd->me, node))) {
+                imcb_log(ic, "WARNING: Couldn't generate server query");
+                xt_free_node(node);
+        }
+
+        jabber_cache_add(ic, query, jabber_iq_parse_gmail);
+
+        return jabber_write_packet(ic, query) ? XT_HANDLED : XT_ABORT;
+}
+
 xt_status jabber_iq_parse_server_features(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
 
@@ -729 +784 @@
 
         return jabber_write_packet(ic, query) ? XT_HANDLED : XT_ABORT;
+}
+
+xt_status jabber_iq_parse_gmail(struct im_connection *ic, struct xt_node *node, struct xt_node *orig)
+{
+        struct xt_node *c;
+        struct jabber_data *jd = ic->proto_data;
+        char *xmlns, *from;
+        guint64 l_time = 0;
+        char *tid = NULL;
+        int max = 0;
+
+        if (!(c = xt_find_node(node->children, "mailbox")) ||
+            !(from = xt_find_attr(node, "from")) ||
+            !(xmlns = xt_find_attr(c, "xmlns")) ||
+            (g_strcmp0(xmlns, XMLNS_GMAILNOTIFY) != 0)) {
+                imcb_log(ic, "WARNING: Received incomplete mailbox packet for gmail notify");
+                return XT_HANDLED;
+        }
+
+        max = set_getint(&ic->acc->set, "mail_notifications_limit");
+        c = c->children;
+
+        while ((max-- > 0) && (c = xt_find_node(c, "mail-thread-info"))) {
+                struct xt_node *s;
+                char *subject = "<no subject>";
+                char *sender = "<no sender>";
+                guint64 t_time;
+
+                t_time = g_ascii_strtoull(xt_find_attr(c, "date"), NULL, 10);
+                if (t_time && t_time > l_time) {
+                        l_time = t_time;
+                        tid = xt_find_attr(c, "tid");
+                }
+
+                if ((s = xt_find_node(c->children, "senders")) &&
+                    (s = xt_find_node_by_attr(s->children, "sender", "unread", "1"))) {
+                        sender = xt_find_attr(s, "name");
+                }
+
+                if ((s = xt_find_node(c->children, "subject")) && s->text) {
+                        subject = s->text;
+                }
+
+                imcb_notify_email(ic, "New mail from %s: %s", sender, subject);
+
+                c = c->next;
+        }
+
+        if (l_time && (!jd->gmail_time || l_time > jd->gmail_time)) {
+                jd->gmail_time = l_time;
+                if (tid) {
+                        g_free(jd->gmail_tid);
+                        jd->gmail_tid = g_strdup(tid);
+                }
+        }
+
+        return XT_HANDLED;
 }
 
@@ -781 +893 @@
                         c = c->next;
                 }
+
+                if (jd->flags & JFLAG_GMAILNOTIFY) {
+                        /* search for gmail notification feature */
+                        c = xt_find_node(node->children, "query");
+                        c = c->children;
+                        while ((c = xt_find_node(c, "feature"))) {
+                                if (strcmp(xt_find_attr(c, "var"), XMLNS_GMAILNOTIFY) == 0) {
+                                        jabber_iq_query_gmail(ic);
+                                }
+                                c = c->next;
+                        }
+                }
+
         } else if (strcmp(xmlns, XMLNS_BYTESTREAMS) == 0) {
                 char *host, *jid, *port_s;

protocols/jabber/jabber.c

@@ -100 +100 @@
 
         s = set_add(&acc->set, "xmlconsole", "false", set_eval_bool, acc);
+
+        s = set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
         s->flags |= ACC_SET_OFFLINE_ONLY;
+
+        /* changing this is rarely needed so keeping it secret */
+        s = set_add(&acc->set, "mail_notifications_limit", "5", set_eval_int, acc);
+        s->flags |= SET_HIDDEN_DEFAULT;
+
+        s = set_add(&acc->set, "mail_notifications_handle", NULL, NULL, acc);
+        s->flags |= ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
 
         acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE |
@@ -260 +269 @@
         }
 
+        if (set_getbool(&acc->set, "mail_notifications")) {
+                /* It's gmail specific, but it checks for server support before enabling it */
+                jd->flags |= JFLAG_GMAILNOTIFY;
+                if (set_getstr(&acc->set, "mail_notifications_handle")) {
+                        imcb_add_buddy(ic, set_getstr(&acc->set, "mail_notifications_handle"), NULL);
+                }
+        }
+
         jabber_generate_id_hash(jd);
 }
@@ -334 +351 @@
         g_free(jd->away_message);
         g_free(jd->internal_jid);
+        g_free(jd->gmail_tid);
         g_free(jd->username);
         g_free(jd->me);

protocols/jabber/jabber.h

@@ -46 +46 @@
         JFLAG_XMLCONSOLE = 64,          /* If the user added an xmlconsole buddy. */
         JFLAG_STARTTLS_DONE = 128,      /* If a plaintext session was converted to TLS. */
+        JFLAG_GMAILNOTIFY = 256,        /* If gmail notification is enabled */
 
         JFLAG_GTALK =  0x100000,        /* Is Google Talk, as confirmed by iq discovery */
@@ -102 +103 @@
         const struct jabber_away_state *away_state;
         char *away_message;
+        guint64 gmail_time;
+        char *gmail_tid;
 
         md5_state_t cached_id_prefix;
@@ -224 +227 @@
 #define XMLNS_DELAY        "urn:xmpp:delay"                                      /* XEP-0203 */
 #define XMLNS_XDATA        "jabber:x:data"                                       /* XEP-0004 */
+#define XMLNS_GMAILNOTIFY  "google:mail:notify"                                  /* Not a XEP */
 #define XMLNS_CHATSTATES   "http://jabber.org/protocol/chatstates"               /* XEP-0085 */
 #define XMLNS_DISCO_INFO   "http://jabber.org/protocol/disco#info"               /* XEP-0030 */

protocols/msn/msn.c

@@ -46 +46 @@
         s->flags |= ACC_SET_OFFLINE_ONLY;
 
-        set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
+        s = set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
+        s->flags |= ACC_SET_OFFLINE_ONLY;
+
+        s = set_add(&acc->set, "mail_notifications_handle", NULL, NULL, acc);
+        s->flags |= ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
 
         acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE |
@@ -82 +86 @@
         msn_ns_connect(ic, server,
                        set_getint(&ic->acc->set, "port"));
+
+        if (set_getbool(&acc->set, "mail_notifications") && set_getstr(&acc->set, "mail_notifications_handle")) {
+                imcb_add_buddy(ic, set_getstr(&acc->set, "mail_notifications_handle"), NULL);
+        }
 }
 

protocols/msn/ns.c

@@ -394 +394 @@
 
                                         if (inbox && folders) {
-                                                imcb_log(ic,
-                                                         "INBOX contains %s new messages, plus %s messages in other folders.", inbox,
-                                                         folders);
+                                                imcb_notify_email(ic,
+                                                        "INBOX contains %s new messages, plus %s messages in other folders.", inbox,
+                                                        folders);
                                         }
 
@@ -408 +408 @@
 
                                         if (from && fromname) {
-                                                imcb_log(ic, "Received an e-mail message from %s <%s>.", fromname,
-                                                         from);
+                                                imcb_notify_email(ic, "Received an e-mail message from %s <%s>.", fromname, from);
                                         }
 

protocols/purple/purple.c

@@ -238 +238 @@
                 s = set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
                 s->flags |= ACC_SET_OFFLINE_ONLY;
+
+                s = set_add(&acc->set, "mail_notifications_handle", NULL, NULL, acc);
+                s->flags |= ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
         }
 
@@ -332 +335 @@
 
         purple_account_set_enabled(pd->account, "BitlBee", TRUE);
+
+        if (set_getbool(&acc->set, "mail_notifications") && set_getstr(&acc->set, "mail_notifications_handle")) {
+                imcb_add_buddy(ic, set_getstr(&acc->set, "mail_notifications_handle"), NULL);
+        }
 }
 
@@ -1255 +1262 @@
         struct im_connection *ic = purple_ic_by_gc(gc);
 
-        imcb_log(ic, "Received e-mail from %s for %s: %s <%s>", from, to, subject, url);
+        imcb_notify_email(ic, "Received e-mail from %s for %s: %s <%s>", from, to, subject, url);
 
         return NULL;

protocols/yahoo/yahoo.c

@@ -123 +123 @@
 static void byahoo_init(account_t *acc)
 {
-        set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
+        set_t *s;
+
+        s = set_add(&acc->set, "mail_notifications", "false", set_eval_bool, acc);
+        s->flags |= ACC_SET_OFFLINE_ONLY;
+
+        s = set_add(&acc->set, "mail_notifications_handle", NULL, NULL, acc);
+        s->flags |= ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
 
         acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
@@ -145 +151 @@
         yd->y2_id = yahoo_init(acc->user, acc->pass);
         yahoo_login(yd->y2_id, yd->current_status);
+
+        if (set_getbool(&acc->set, "mail_notifications") && set_getstr(&acc->set, "mail_notifications_handle")) {
+                imcb_add_buddy(ic, set_getstr(&acc->set, "mail_notifications_handle"), NULL);
+        }
 }
 
@@ -950 +960 @@
         struct im_connection *ic = byahoo_get_ic_by_id(id);
 
-        if (!set_getbool(&ic->acc->set, "mail_notifications")) {
-                ; /* The user doesn't care. */
-        } else if (from && subj) {
-                imcb_log(ic, "Received e-mail message from %s with subject `%s'", from, subj);
+        if (from && subj) {
+                imcb_notify_email(ic, "Received e-mail message from %s with subject `%s'", from, subj);
         } else if (cnt > 0) {
-                imcb_log(ic, "Received %d new e-mails", cnt);
+                imcb_notify_email(ic, "Received %d new e-mails", cnt);
         }
 }