Changeset c6bf805 for protocols/yahoo

Timestamp:

2010-07-25T13:59:12Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

3fa5a8c

Parents:

51a3d12

Message:

Some NULL pointer checks for libyahoo2 - this code's currently crashing
because BitlBee ignores file transfers.

File:

• protocols/yahoo/libyahoo2.c (modified) (4 diffs)

protocols/yahoo/libyahoo2.c

@@ -4830 +4830 @@
 static void yahoo_remove_active_transfer(struct send_file_data *sfd)
 {
+        if (sfd == NULL)
+                return;
+        
         active_file_transfers = y_list_remove(active_file_transfers, sfd);
         free(sfd->id);
@@ -4990 +4993 @@
                 YAHOO_CALLBACK(ext_yahoo_file_transfer_done)
                         (yid->yd->client_id, YAHOO_FILE_TRANSFER_UNKNOWN,
-                        sfd->data);
+                        sfd ? sfd->data : NULL);
 
                 yahoo_remove_active_transfer(sfd);
@@ -5046 +5049 @@
                 YAHOO_CALLBACK(ext_yahoo_file_transfer_done)
                         (yid->yd->client_id, YAHOO_FILE_TRANSFER_UNKNOWN,
-                        sfd->data);
+                        sfd ? sfd->data : NULL);
 
                 yahoo_remove_active_transfer(sfd);
@@ -5161 +5164 @@
                         YAHOO_CALLBACK(ext_yahoo_file_transfer_done)
                                 (yd->client_id, YAHOO_FILE_TRANSFER_REJECT,
-                                sfd->data);
+                                sfd ? sfd->data : NULL);
 
                         yahoo_remove_active_transfer(sfd);