Changes in protocols/jabber/conference.c [9698fc0:c34247d]

File:

• protocols/jabber/conference.c (modified) (8 diffs)

protocols/jabber/conference.c

@@ -28 +28 @@
 static xt_status jabber_chat_self_message(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
 
-struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password,
-                                   gboolean always_use_nicks)
+struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password)
 {
         struct jabber_chat *jc;
@@ -58 +57 @@
                 g_free(jc);
                 return NULL;
-        }
-
-        if (always_use_nicks) {
-                jc->flags = JCFLAG_ALWAYS_USE_NICKS;
         }
 
@@ -100 +95 @@
         g_free(cserv);
 
-        c = jabber_chat_join(ic, rjid, jd->username, NULL, FALSE);
+        c = jabber_chat_join(ic, rjid, jd->username, NULL);
         g_free(rjid);
         if (c == NULL) {
@@ -249 +244 @@
 }
 
-static int jabber_chat_has_other_resources(struct im_connection *ic, struct jabber_buddy *bud)
-{
-        struct jabber_buddy *cur;
-
-        for (cur = jabber_buddy_by_jid(ic, bud->bare_jid, GET_BUDDY_FIRST); cur; cur = cur->next) {
-                if (cur != bud && jabber_compare_jid(cur->ext_jid, bud->ext_jid)) {
-                        return TRUE;
-                }
-        }
-        
-        return FALSE;
-}
-
 /* Not really the same syntax as the normal pkt_ functions, but this isn't
    called by the xmltree parser directly and this way I can add some extra
@@ -346 +328 @@
                         *s = 0; /* Should NEVER be NULL, but who knows... */
                 }
-
-                if (bud != jc->me && (jc->flags & JCFLAG_ALWAYS_USE_NICKS) && !(bud->flags & JBFLAG_IS_ANONYMOUS)) {
-                        imcb_buddy_nick_change(ic, bud->ext_jid, bud->resource);
-                }
-
                 imcb_chat_add_buddy(chat, bud->ext_jid);
                 if (s) {
@@ -356 +333 @@
                 }
         } else if (type) { /* type can only be NULL or "unavailable" in this function */
-                if ((bud->flags & JBFLAG_IS_CHATROOM) && bud->ext_jid && !jabber_chat_has_other_resources(ic, bud)) {
+                if ((bud->flags & JBFLAG_IS_CHATROOM) && bud->ext_jid) {
                         char *reason = NULL;
                         char *status = NULL;
@@ -466 +443 @@
 
         if (subject && chat) {
-                char empty[1] = "";
-                char *subject_text = subject->text_len > 0 ? subject->text : empty;
+                char *subject_text = subject->text_len > 0 ? subject->text : "";
                 if (g_strcmp0(chat->topic, subject_text) != 0) {
                         bare_jid = (bud) ? jabber_get_bare_jid(bud->ext_jid) : NULL;
@@ -503 +479 @@
                 bare_jid = jabber_get_bare_jid(bud->ext_jid ? bud->ext_jid : bud->full_jid);
                 final_from = bare_jid;
-                if (bud == jc->me || (g_strcasecmp(final_from, ic->acc->user) == 0)) {
-                        flags = OPT_SELFMESSAGE;
-                }
+                flags = (bud == jc->me) ? OPT_SELFMESSAGE : 0;
         } else {
                 final_from = nick;